Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ private void clearHistory() {
* Makes the current history page the last one in the history.
*/
private void clearHistoryAfterCurrentPos() {
for (int i=history.size()-1; i>historyPos; i--) {
history.remove(i);
if (history.size() > historyPos + 1) {
history.subList(historyPos + 1, history.size()).clear();
}
setActionStates();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public void loadFromXML(InputStream in, ClassLoader cl) throws IOException {
char endChar = handler.getParamEndChar();
String sep = handler.getParamSeparator();
// Sanity check. Note endChar can be null
if (sep != null && sep.length() > 0) {
if (sep != null && !sep.isEmpty()) {
setParameterizedCompletionParams(startChar, sep, endChar);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ else if (visibleRowCount>0) {
public void setVisible(boolean visible) {
if (visible!=isVisible()) {
// i.e. if no possibilities matched what's been typed
if (visible && model.size()==0) {//list.getVisibleRowCount()==0) {
if (visible && model.isEmpty()) {//list.getVisibleRowCount()==0) {
return;
}
super.setVisible(visible);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
class AbstractCompletionProviderTest {

/**
* Regression test for https://github.com/bobbylight/AutoComplete/issues/101 -
* Regression test for <a href="https://github.com/bobbylight/AutoComplete/issues/101">#101</a> -
* when several completions share the same input text (e.g. overloaded
* methods), the first one in the sorted completion list was never
* included in the returned results, due to an off-by-one error.
Expand Down
8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

plugins {
id 'com.github.spotbugs' version '6.5.9'
id 'com.github.spotbugs' version '6.5.10'
id 'io.github.gradle-nexus.publish-plugin' version '2.0.0'
}

Expand All @@ -31,7 +31,7 @@ allprojects {
}

wrapper {
gradleVersion = '9.6.1'
gradleVersion = '9.7.0'
}
}

Expand All @@ -50,7 +50,7 @@ subprojects {
}

checkstyle {
toolVersion = '13.8.0'
toolVersion = '13.11.0'
configDirectory = file("$rootProject.projectDir/config/checkstyle")
}

Expand Down Expand Up @@ -81,7 +81,7 @@ subprojects {
}

dependencies {
testImplementation platform('org.junit:junit-bom:6.0.1')
testImplementation platform('org.junit:junit-bom:6.1.3')
testImplementation 'org.junit.jupiter:junit-jupiter'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
}
Expand Down
5 changes: 4 additions & 1 deletion config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@
<property name="accessModifiers" value="package"/>
</module>
-->
<module name="JavadocStyle"/>
<module name="AtclauseOrder"/>
<module name="InvalidJavadocPosition"/>
<module name="JavadocBlockTagLocation"/>
Expand All @@ -124,6 +123,7 @@
<module name="JavadocTagContinuationIndentation"/>
<module name="NonEmptyAtclauseDescription"/>
<module name="RequireEmptyLineBeforeBlockTagGroup"/>
<module name="SummaryJavadoc"/>
<module name="MissingJavadocMethod">
<property name="allowMissingPropertyJavadoc" value="true"/>
<property name="tokens" value="METHOD_DEF, ANNOTATION_FIELD_DEF"/>
Expand Down Expand Up @@ -173,6 +173,7 @@

<!-- Checks for whitespace -->
<!-- See https://checkstyle.sourceforge.io/checks/whitespace/index.html -->
<module name="ArrayBracketNoWhitespace"/>
<module name="EmptyForIteratorPad"/>
<module name="GenericWhitespace"/>
<module name="MethodParamPad"/>
Expand Down Expand Up @@ -254,6 +255,7 @@
<module name="UnnecessarySemicolonAfterTypeMemberDeclaration"/>
<module name="UnnecessarySemicolonInEnumeration"/>
<module name="UnnecessarySemicolonInTryWithResources"/>
<module name="UnnecessaryTypeArgumentsWithRecordPattern"/>
<module name="UnusedLocalVariable"/>
<module name="UnusedTryResourceShouldBeUnnamed"/>
<!--<module name="UseEnhancedSwitch"/> - TODO: too noisy for now -->
Expand All @@ -276,6 +278,7 @@
<module name="AvoidEscapedUnicodeCharacters"/>
<module name="CommentsIndentation"/>
<!--<module name="FinalParameters"/>-->
<module name="MultilineCommentLeadingAsteriskPresence"/>
<module name="NumericalPrefixesInfixesSuffixesCharacterCase"/>
<!-- <module name="TodoComment"/> -->
<module name="UpperEll"/>
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.6.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.0-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
Loading