Bump Gradle/checkstyle/spotbugs/JUnit versions; enable new checkstyle rules - #124
Merged
Merged
Conversation
…ckstyle rules - Gradle wrapper 9.6.1 -> 9.7.0 - checkstyle tool version 13.8.0 -> 13.11.0 - spotbugs plugin 6.5.9 -> 6.5.10 - junit-bom 6.0.1 -> 6.1.3 - Enables SummaryJavadoc, ArrayBracketNoWhitespace, UnnecessaryTypeArgumentsWithRecordPattern, and MultilineCommentLeadingAsteriskPresence; removes JavadocStyle (superseded) - Fixes the resulting violations: prefer String#isEmpty()/Collection#isEmpty() over length()/size() comparisons, use List#subList().clear() instead of a manual removal loop, and use an HTML anchor for a Javadoc issue link Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SummaryJavadoc,ArrayBracketNoWhitespace,UnnecessaryTypeArgumentsWithRecordPattern,MultilineCommentLeadingAsteriskPresence; removesJavadocStyle(superseded by newer checks)String#isEmpty()/Collection#isEmpty()overlength()/size()comparisons, useList#subList().clear()instead of a manual backwards removal loop, and use an HTML anchor for a Javadoc issue linkTest plan
./gradlew build— full build (compile, checkstyle, tests) passes on all modules with the new tool versions and rules