Fix mobile header layout - #270
Draft
jpers1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The header grid did not give its center column a shrinkable track, and the full user label continued to consume width on narrow screens. Long book titles could therefore collide with adjacent controls or widen the layout. The mobile rule now uses
auto minmax(0, 1fr) auto, constrains the title to one ellipsized line, and hides the verbose label while preserving the user control. Desktop behavior is unchanged.Scope
This PR addresses only narrow-screen header geometry. It does not include the separate
ExpandingSideImgfix and does not address broader document-level horizontal overflow. Mobile WebKit coverage uses Playwright iPhone 13 emulation, not a physical Safari device.Validation
yarn install --frozen-lockfileyarn test:e2e(2 passed: desktop Chromium and mobile WebKit)yarn test:e2e:mobile(1 passed)yarn buildyarn check-translationsgit diff --checkAt a 390 CSS-pixel viewport, the regression records a 390-pixel header, a single painted title line, no home/title overlap, the avatar fully inside the header, the verbose user label hidden, and no fixture-level horizontal overflow.