Fix expanding side images on mobile - #271
Draft
jpers1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The desktop
ExpandingSideImgrules position and transform the image wrapper for its side expansion behavior. The previous mobile rule adjusted the image width but did not override that positioning and transform with sufficient specificity, so narrow-screen side images could remain displaced or effectively absent. The mobile rule now targetsdiv.expanding-side-img, restores normal flow withposition: static, removes the transform, and constrains both wrapper and image dimensions.Scope
This PR addresses only
ExpandingSideImgbehavior on narrow screens. It is independent of the mobile header fix in #270 and does not address the separate document-level horizontal-overflow investigation. Mobile WebKit coverage uses Playwright iPhone 13 emulation, not a physical Safari device.Validation
yarn install --frozen-lockfileyarn test:e2e(4 passed: baseline and side-image tests in desktop Chromium and mobile WebKit)yarn test:e2e:mobile(2 passed)yarn buildyarn check-translationsgit diff --checkAt a 390 CSS-pixel viewport, the regression records a 374-pixel image inside its 374-pixel container,
position: static, no transform, preserved 16:9 aspect ratio, visible caption and child content, following content below the component, and no fixture-level horizontal overflow.