fix(binary): move logging into main thread for binary compatibility. #1804
fix(binary): move logging into main thread for binary compatibility. #1804Hweinstock wants to merge 4 commits into
Conversation
10c9c14 to
a2e8a64
Compare
a2e8a64 to
d45048d
Compare
| - name: macOS | ||
| runner: '["macos-latest"]' | ||
| target: darwin-arm64 | ||
| binary: ./dist/bin/agentcore-darwin-arm64 |
There was a problem hiding this comment.
Would a simpler way of doing all this just be to call make? Bun can cross-compile.
There was a problem hiding this comment.
I think we need to do it individually since the matrix is parallelizing across runners so each runner needs its own binary.
|
closed in favor of #1808 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1804 +/- ##
============================================
- Coverage 93.91% 93.89% -0.02%
============================================
Files 118 118
Lines 6423 6426 +3
============================================
+ Hits 6032 6034 +2
- Misses 391 392 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
Problem
#1801
The logger is failing to initialize when the CLI is compiled to a binary. See the issue for a root cause.
Solution
Testing