Skip to content

fix(binary): move logging into main thread for binary compatibility. #1804

Closed
Hweinstock wants to merge 4 commits into
aws:refactorfrom
Hweinstock:fix/pino-exec
Closed

fix(binary): move logging into main thread for binary compatibility. #1804
Hweinstock wants to merge 4 commits into
aws:refactorfrom
Hweinstock:fix/pino-exec

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

#1801

The logger is failing to initialize when the CLI is compiled to a binary. See the issue for a root cause.

Solution

  • move the logger into the main thread by instantiating the stream with the logger.
  • revert back to using console.error at the top level to surface errors.
  • add a CI job that compiles the binary on each platform to add protection against this going forward.

Testing

  • CI job is passing.
  • local binary works now after the fix.

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 22, 2026
@Hweinstock
Hweinstock force-pushed the fix/pino-exec branch 3 times, most recently from 10c9c14 to a2e8a64 Compare July 22, 2026 16:11
- name: macOS
runner: '["macos-latest"]'
target: darwin-arm64
binary: ./dist/bin/agentcore-darwin-arm64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a simpler way of doing all this just be to call make? Bun can cross-compile.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to do it individually since the matrix is parallelizing across runners so each runner needs its own binary.

@Hweinstock

Copy link
Copy Markdown
Contributor Author

closed in favor of #1808

@Hweinstock Hweinstock closed this Jul 22, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (951044e) to head (1c5ee77).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1804      +/-   ##
============================================
- Coverage     93.91%   93.89%   -0.02%     
============================================
  Files           118      118              
  Lines          6423     6426       +3     
============================================
+ Hits           6032     6034       +2     
- Misses          391      392       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the report, @codecov-commenter — feedback like this is exactly
how we catch the things we missed. Because this PR is already
closed, the team won't see follow-up comments here.

Would you mind opening a new issue so we can track it properly?
https://github.com/aws/agentcore-cli/issues/new/choose

If this is a security issue, please report it privately via
https://aws.amazon.com/security/vulnerability-reporting/ instead
of a public issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants