Conversation
There was a problem hiding this comment.
Pull request overview
Updates Archinstall’s Spanish (es) localization strings and refreshes the gettext template/compiled artifacts.
Changes:
- Fill in previously untranslated Spanish
msgstrentries (navigation/help/pacman/font/KDE strings) inbase.po. - Add new translation entries for recently introduced U2F-related prompts.
- Regenerate
base.moand updatebase.pot.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
archinstall/locales/es/LC_MESSAGES/base.po |
Adds/updates Spanish translations for multiple UI strings and introduces new U2F-related entries. |
archinstall/locales/es/LC_MESSAGES/base.mo |
Regenerated compiled Spanish message catalog from the updated .po. |
archinstall/locales/base.pot |
Updates the base translation template with new msgids (including U2F-related strings). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Github copilot suggested
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Github suggestions
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| msgid "Setting up U2F login: {u2f_config.u2f_login_method.value}" | ||
| msgstr "Configurando Inicio U2F: {u2f_config.u2f_login_method.value}" | ||
|
|
||
| #, fuzzy, python-brace-format |
There was a problem hiding this comment.
This new translation is marked fuzzy. With the current build script using msgfmt without -f, it will be dropped from base.mo and users will see the English string. Remove the fuzzy flag if the translation is final.
| #, fuzzy, python-brace-format | |
| #, python-brace-format |
| msgid "Scroll Up" | ||
| msgstr "" | ||
| msgstr "Mover Arriba" | ||
|
|
||
| #, fuzzy | ||
| msgid "Scroll Down" | ||
| msgstr "Bajar en vista previa" | ||
|
|
||
| msgid "Scroll Left" | ||
| msgstr "" | ||
| msgstr "Mover Izquierda" |
There was a problem hiding this comment.
Capitalization is inconsistent with nearby Spanish translations (e.g., "Mover a la derecha", "Arriba/Abajo"). Consider using sentence case for directions here as well (e.g., "Mover arriba/izquierda/derecha") to keep the UI consistent.
| "Provides a selection of desktop environments and tiling window managers, e." | ||
| "g. gnome, kde, sway" |
There was a problem hiding this comment.
The msgid wrapping splits the abbreviation "e.g." across lines ("e." / "g."), creating unnecessary diff noise and making the template harder to read/translate. Please rewrap at a word boundary (as is done for the similar string around line ~657).
| "Provides a selection of desktop environments and tiling window managers, e." | |
| "g. gnome, kde, sway" | |
| "Provides a selection of desktop environments and tiling window managers, e.g. " | |
| "gnome, kde, sway" |
| "Provides a selection of desktop environments and tiling window managers, e." | ||
| "g. GNOME, KDE Plasma, Sway" |
There was a problem hiding this comment.
Same wrapping issue here: splitting "e.g." across lines makes the POT harder to read and creates avoidable diffs. Please rewrap at a word boundary.
| "Provides a selection of desktop environments and tiling window managers, e." | |
| "g. GNOME, KDE Plasma, Sway" | |
| "Provides a selection of desktop environments and tiling window managers, " | |
| "e.g. GNOME, KDE Plasma, Sway" |
Translation of "es" Language
I have translate different word from English in to Spanish.