[Web] Avoid copies when uploading WASM memory to WebGPU - #20165
Open
akaashrp wants to merge 1 commit into
Open
Conversation
queue.writeBuffer copies its source before returning, so aligned uploads can read directly from Wasm linear memory instead of first copying into another Uint8Array. Use a checked view for aligned transfers. Keep the padded buffer for unaligned lengths, and align GPU allocations and readback copies to WebGPU copy requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an intermediate
Uint8Arraycopy when uploading aligned data from WASM memory to WebGPU.GPUQueue.writeBufferwriteBuffersnapshots its source before returning, so the borrowed WASM view does not need to remain valid after the call.