Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Eliminating underscore#4410

Open
ocket8888 wants to merge 4 commits intoapache:masterfrom
ocket8888:eliminating-underscore
Open

Eliminating underscore#4410
ocket8888 wants to merge 4 commits intoapache:masterfrom
ocket8888:eliminating-underscore

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Removes UnderscoreJS (_.js) from the Traffic Portal dependencies and codebase.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Run the existing end-to-end TP tests, but also start a TP instance and pay close attention to any errors coming from the jQuery "data tables" and the charts on the dashboard. I think those are using lodash/defining their own variables named _, but the problem could just not be manifesting for me for some reason.

The following criteria are ALL met by this PR

  • Existing tests should be sufficient
  • Documentation of managed dependencies is not necessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. labels Feb 18, 2020
@mitchell852
Copy link
Copy Markdown
Member

this is good (it's always good to remove a dependency imo) but it's highly intrusive and dangerous as the reality is that the TP end-to-end tests probably don't cover many of these "states" (not sure however). Bottom line: this is going to require a good deal of testing which is fine. Just wanted to point that out if someone (besides me) ends up reviewing/merging this.

@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 9d63213 to 3a3846b Compare March 11, 2020 23:05
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 3a3846b to add1cb6 Compare April 20, 2020 17:07
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from add1cb6 to a3e0352 Compare April 29, 2020 21:29
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch 2 times, most recently from 386d1c9 to ba6f230 Compare June 17, 2020 17:08
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from ba6f230 to 3dbc700 Compare October 16, 2020 17:43
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 3dbc700 to 5fdd5c0 Compare October 30, 2020 14:53
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 19e2da4 to 7ec739e Compare January 7, 2021 22:19
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 7ec739e to ef93556 Compare April 7, 2021 15:49
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from ef93556 to 38b8919 Compare April 26, 2021 23:57
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 38b8919 to d926f61 Compare May 18, 2021 14:33
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from d926f61 to 6bd7b6d Compare August 5, 2021 15:32
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 6bd7b6d to 1014fe0 Compare August 17, 2021 14:36
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 1014fe0 to 17c5464 Compare October 22, 2021 16:30
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 17c5464 to 8147de0 Compare January 11, 2022 21:26
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 8147de0 to e39a9a1 Compare February 25, 2022 21:49
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from e39a9a1 to 93c5ad8 Compare July 18, 2022 18:08
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from f8d200b to 2ff9a62 Compare September 30, 2022 16:40
@ocket8888 ocket8888 force-pushed the eliminating-underscore branch from 2ff9a62 to 3eedac2 Compare October 27, 2022 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants