This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Eliminating underscore#4410
Open
ocket8888 wants to merge 4 commits intoapache:masterfrom
Open
Conversation
Member
|
this is good (it's always good to remove a dependency imo) but it's highly intrusive and dangerous as the reality is that the TP end-to-end tests probably don't cover many of these "states" (not sure however). Bottom line: this is going to require a good deal of testing which is fine. Just wanted to point that out if someone (besides me) ends up reviewing/merging this. |
9d63213 to
3a3846b
Compare
7 tasks
3a3846b to
add1cb6
Compare
add1cb6 to
a3e0352
Compare
386d1c9 to
ba6f230
Compare
ba6f230 to
3dbc700
Compare
3dbc700 to
5fdd5c0
Compare
19e2da4 to
7ec739e
Compare
7ec739e to
ef93556
Compare
ef93556 to
38b8919
Compare
38b8919 to
d926f61
Compare
d926f61 to
6bd7b6d
Compare
6bd7b6d to
1014fe0
Compare
1014fe0 to
17c5464
Compare
17c5464 to
8147de0
Compare
8147de0 to
e39a9a1
Compare
e39a9a1 to
93c5ad8
Compare
f8d200b to
2ff9a62
Compare
2ff9a62 to
3eedac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Removes UnderscoreJS (
_.js) from the Traffic Portal dependencies and codebase.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the existing end-to-end TP tests, but also start a TP instance and pay close attention to any errors coming from the jQuery "data tables" and the charts on the dashboard. I think those are using lodash/defining their own variables named
_, but the problem could just not be manifesting for me for some reason.The following criteria are ALL met by this PR