This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Deprecate cachegroup/:id/unassigned_parameters#4423
Merged
ocket8888 merged 8 commits intoapache:masterfrom Mar 16, 2020
Merged
Conversation
mitchell852
added
documentation
ocket8888
reviewed
Feb 26, 2020
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Besides a changelog conflict, TP is also using this endpoint - can you replicate the behavior in the api handler? I think it's in CacheGroupService.js but it might be ParameterService.js.
Contributor
Author
|
All done 👍 |
ocket8888
reviewed
Mar 11, 2020
ocket8888
reviewed
Mar 13, 2020
ocket8888
reviewed
Mar 16, 2020
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Docs build without errors/warnings and look accurate, all unit and client/api integration tests passing, manually verified that the route is not in 2.0 and returns a deprecation notice in 1.x, manually verified that in TP the list of link-able parameters is filtered appropriately and linking is done properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run traffic ops and make sure you can not hit the endpoint in API 2.0 and when performing a GET on it in 1.x you receive a deprecation message back in the returned alerts.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information