Skip to content

[#2818] bugfix(matcher): prevent accidental matches for simulated credentials in… - #2856

Open
lprimak wants to merge 1 commit into
apache:mainfrom
lprimak:simulator-compatible-with-all-matcher
Open

[#2818] bugfix(matcher): prevent accidental matches for simulated credentials in…#2856
lprimak wants to merge 1 commit into
apache:mainfrom
lprimak:simulator-compatible-with-all-matcher

Conversation

@lprimak

@lprimak lprimak commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

… multi-realm setup, causing errors printed on the console whene they should not be.
fixes #2818

Thank you @arimu1 for your inspiration here
Supersedes #2855

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 3.0.1 milestone Aug 14, 2026
@lprimak
lprimak requested a review from bmarwell August 14, 2026 02:54
@lprimak lprimak self-assigned this Aug 14, 2026
@lprimak lprimak added the core Core Modules label Aug 14, 2026
@github-actions github-actions Bot added java Pull requests that update Java code tests labels Aug 14, 2026
@lprimak lprimak changed the title [#2818] enh(matcher): prevent accidental matches for simulated credentials in… [#2818] bugfix(matcher): prevent accidental matches for simulated credentials in… Aug 14, 2026
… in multi-realm setup, causing errors printed on the console whene they should not be.
@lprimak
lprimak force-pushed the simulator-compatible-with-all-matcher branch from 9d3ec82 to 4fba170 Compare August 14, 2026 02:56
@lprimak
lprimak requested review from raboof and removed request for raboof August 14, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core Modules java Pull requests that update Java code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] AllowAllCredentialsMatcher logs a "matched the simulated credentials" error via simulateFailedLogin

2 participants