[#2818] - Skip simulateFailedLogin for AllowAllCredentialsMatcher - #2855
Closed
arimu1 wants to merge 1 commit into
Closed
[#2818] - Skip simulateFailedLogin for AllowAllCredentialsMatcher#2855arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
AllowAllCredentialsMatcher always matches credentials, so it cannot supply decoy simulated credentials. Return Optional.empty() and cache the opt-out in AuthenticatingRealm to avoid false misconfiguration errors and repeated warnings when a multi-realm setup asks a realm about an unknown principal. Fixes apache#2818
lprimak
requested changes
Aug 13, 2026
Contributor
|
Please check the appropriate box in the description checklist to attribute license and copyright to Apache. Thank you for your contribution. |
Contributor
|
I have reviewed your PR. I think it's way over-complicated. It inspired me to write much simpler PR. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2818.
AllowAllCredentialsMatcheralways returnstruefromdoCredentialsMatch, so it cannot provide decoy simulated credentials that fail matching. When a multi-realm setup asks such a realm about an unknown principal,simulateFailedLoginwas treating the decoy as a misconfiguration and logging a falseIncorrectCredentialsExceptionerror on every login.This change:
Optional.empty()fromAllowAllCredentialsMatcher#createSimulatedCredentials()AuthenticatingRealm#ensureSimulatedAuthenticationInfoso empty simulated credentials are not re-requested on every lookupAllowAllCredentialsMatcher, since opting out is intentionalTest plan
mvn -pl core -am test -Dtest=AllowAllCredentialsMatcherTest,AuthenticatingRealmJavaTest -Dsurefire.failIfNoSpecifiedTests=false(JDK 21)AllowAllCredentialsMatchercreateSimulatedCredentials()is emptyMade with LLM
Checklist
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.