Skip to content

Fixed exception expectation in testDeeplyNestedElements #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coheigea merged 1 commit into from
Jun 5, 2026
Merged

Fixed exception expectation in testDeeplyNestedElements #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/test/java/org/apache/xml/security/test/dom/parser/XMLParserEdgeCasesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.xml.security.utils.XMLUtils;
import org.junit.jupiter.api.Test;
import org.w3c.dom.Document;
import org.xml.sax.SAXParseException;

import java.io.ByteArrayInputStream;
import java.nio.charset.StandardCharsets;
Expand Down Expand Up @@ -153,10 +154,15 @@ void testDeeplyNestedElements() {
try {
XMLUtils.read(bais, false);
} catch (XMLParserException e) {
// Stack overflow protection is acceptable
assertTrue(e.getMessage().contains("depth") ||
e.getMessage().contains("stack") ||
e.getMessage().contains("nested"),
/*
* Stack overflow protection is acceptable - in this case there will be a parent
* SAXParseException with a specific text.
*/
assertTrue(e.getCause() instanceof SAXParseException);
SAXParseException saxEx = (SAXParseException) e.getCause();
assertTrue(saxEx.getMessage().contains("depth") ||
saxEx.getMessage().contains("stack") ||
saxEx.getMessage().contains("nested"),
"Deep nesting should trigger protection");
}
}, "Parser should handle deep nesting gracefully");
Expand Down