Fixed exception expectation in testDeeplyNestedElements#606
Merged
Conversation
coheigea
approved these changes
Jun 5, 2026
Contributor
Author
Oops, confused with another pull request. The change in OpenJDK was introduced in jdk-24+26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test for recent Java versions.
The test has two success paths:
Depth limit in java.xml is set by
jdk.xml.maxElementDepthsystem property.Default value was changed from
0(non-limit) to100since jdk-19+16So, in recent Java versions, the second path is triggered, however the check of the exception object is incorrect.
Original
SAXParseExceptionwith specific text is wrapped intoXMLParserExceptionwith a different message at XMLParserImpl:73santuario-xml-security-java/src/main/java/org/apache/xml/security/parser/XMLParserImpl.java
Line 73 in d5dd9fe
So the test needs to check the type and the message of the cause exception.