FINERACT-2421: Optimize github actions workflow by adamsaghy · Pull Request #5799 · apache/fineract

adamsaghy · 2026-04-23T12:51:55Z

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

Write the commit message as per our guidelines
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow our coding conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Aman-Mittal · 2026-04-23T15:50:52Z


 jobs:
  test:
+    if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }}


I cant seem to agree that we should add this here on existing checks

This is needed since all dependent workflow must wait on build-core to be finished.

Please confirm me What am i seeing that you are trying to cache the Tests on Push, What would happen if Someone does some major work (new feature or changes) in their forked Branch and then raise PR like every PR. Will that work on that. Im seeing it can fail on forked repo with new features. LIke we are not caching e2e tests from forked repo due to security reason.

I am not caching on push anything.

Build-core compiles and generates required files. Once everything built, we are storing in cache the built files.

All workflow depends on build-core so that run first. Once it's finished, we are fetching the built files (compiles classes, generated fineract-client, etc.) from the cache and run the tests, build docker image, etc.

Why the change?

All workflow was independent and standalone which means ALL of them were compiling and regenerating files which is unnecessary and led to java heap space issues.

Ok, So is it like this?

1st -> Build Core will run it will Cache the Compiled files.
2nd -> Other tests will run taking on build files (Cucumber e2e test. and other tests)

Hold it, i am facing some issues when i have excluded buildJavaSdk task

ok, Ping me, when i should rebase

@Aman-Mittal Now it should be okay.

@adamsaghy I have rebased my PRs against your branch you can check PR run on respective PR and
On Push workflow on https://github.com/Aman-Mittal/fineract/actions/workflows/full-build-ci.yml

Aman-Mittal · 2026-04-24T08:26:04Z

Will try to review it by eod.

…

On Fri, 24 Apr, 2026, 1:41 pm Adam Saghy, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/build-mariadb.yml <#5799?email_source=notifications&email_token=AHV6TA56O5T4V54TXE4U4R34XMOR3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWHA4TKNZVGM42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJL3QOJPXEZLWNFSXOX3DNRUWG2Y#discussion_r3136341803> : > permissions: contents: read jobs: test: + if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} @Aman-Mittal <https://github.com/Aman-Mittal> Let me know if you need more information. — Reply to this email directly, view it on GitHub <#5799?email_source=notifications&email_token=AHV6TA7WHNEDO2XSXAVPWGD4XMOR3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWHA4TKNZVGM42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#discussion_r3136341803>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHV6TA7KKTC4DC2FRRGU7DD4XMOR3AVCNFSM6AAAAACYDZ6B4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCNRYHE2TONJTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

adamsaghy

Fixed

Aman-Mittal · 2026-04-25T03:40:16Z

@adamsaghy

All failed runs seems to giving cache miss error
enableCrossOsArchive: false
lookup-only: false
env:
DEVELOCITY_ACCESS_KEY:
IMAGE_NAME: fineract
BASE_URL: https://localhost:8443
TEST_USERNAME: mifos
TEST_PASSWORD: password
TEST_STRONG_PASSWORD: A1b2c3d4e5f$
TEST_TENANT_ID: default
INITIALIZATION_ENABLED: true
EVENT_VERIFICATION_ENABLED: true
ACTIVEMQ_BROKER_URL: tcp://localhost:61616
ACTIVEMQ_TOPIC_NAME: events
JAVA_HOME: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64
JAVA_HOME_21_X64: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: fineract-compiled-Linux-24918448689-3

Aman-Mittal · 2026-04-25T16:08:42Z

+            **/build/resources
+            **/build/tmp
+          key: fineract-compiled-${{ runner.os }}-${{ github.run_id }}-${{ github.run_attempt }}
+          fail-on-cache-miss: true


@adamsaghy Can you reconsider on fail-oncach-miss part - I done a little digging myself it seems that Apache Fineract Repository have only 10 GB of cache limit which can cause cache eviction

Aman-Mittal · 2026-04-25T16:15:09Z

@adamsaghy It seems The caches generated by your CI generating is ranging from 400MB to 900MB each which will likely overload cache of this repo at scale.

somasorosdpc approved these changes Apr 23, 2026

View reviewed changes

adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch from 201d575 to 2d12d94 Compare April 23, 2026 15:21

Aman-Mittal reviewed Apr 23, 2026

View reviewed changes

Comment thread .github/workflows/build-mysql.yml

Aman-Mittal reviewed Apr 23, 2026

View reviewed changes

Comment thread .github/workflows/build-progressive-loan.yml

adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch 4 times, most recently from a2c1dca to 416b469 Compare April 23, 2026 17:36

Aman-Mittal mentioned this pull request Apr 24, 2026

FINERACT-2590: MultitenantFix for JournalEntryAggregation job #5802

Open

6 tasks

adamsaghy mentioned this pull request Apr 24, 2026

FINERACT-1222: Add Swagger tags for Journal Entries #5795

Open

6 tasks

adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch 3 times, most recently from 3c4a544 to ff11734 Compare April 24, 2026 16:31

Aman-Mittal reviewed Apr 24, 2026

View reviewed changes

Comment thread .github/workflows/build-e2e-tests.yml Outdated

FINERACT-2421: Optimize github actions workflow

80db9eb

adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch from ff11734 to 80db9eb Compare April 25, 2026 00:48

adamsaghy commented Apr 25, 2026

View reviewed changes

adamsaghy closed this Apr 25, 2026

adamsaghy reopened this Apr 25, 2026

Aman-Mittal reviewed Apr 25, 2026

View reviewed changes

Conversation

adamsaghy commented Apr 23, 2026

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Aman-Mittal commented Apr 24, 2026 via email

Uh oh!

Uh oh!

adamsaghy left a comment

Choose a reason for hiding this comment

Uh oh!

Aman-Mittal commented Apr 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aman-Mittal commented Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants