Skip to content

FINERACT-1222: Add Swagger tags for Journal Entries#5795

Open
elicsmit wants to merge 1 commit intoapache:developfrom
elicsmit:fix-swagger-tags-journal
Open

FINERACT-1222: Add Swagger tags for Journal Entries#5795
elicsmit wants to merge 1 commit intoapache:developfrom
elicsmit:fix-swagger-tags-journal

Conversation

@elicsmit
Copy link
Copy Markdown

@elicsmit elicsmit commented Apr 23, 2026

Description

Added missing Swagger tags for Journal Entries API to improve documentation coverage.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch 2 times, most recently from da273cb to 23c7c7a Compare April 23, 2026 07:09
@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch 16 times, most recently from ce806f4 to d38e50d Compare April 24, 2026 08:47
@elicsmit
Copy link
Copy Markdown
Author

I've updated gradle.properties to -Xmx14g as suggested in the community chats (see the attached screenshot from Dhananjay Bhagat), but the :fineract-client:buildJavaSdk task still fails with Java heap space on the CI server. It seems the standard GitHub Actions runner might not have enough resources for this memory-intensive task. Could you please check if it's possible to run this build on a larger runner or if there's another workaround?

@adamsaghy
Copy link
Copy Markdown
Contributor

I've updated gradle.properties to -Xmx14g as suggested in the community chats (see the attached screenshot from Dhananjay Bhagat), but the :fineract-client:buildJavaSdk task still fails with Java heap space on the CI server. It seems the standard GitHub Actions runner might not have enough resources for this memory-intensive task. Could you please check if it's possible to run this build on a larger runner or if there's another workaround?

No need. this will fix: #5799

you can revert this memory allocation change

@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch from d38e50d to d21aca5 Compare April 24, 2026 10:26
@elicsmit
Copy link
Copy Markdown
Author

Done. I've reverted the changes in gradle.properties. Thanks for the fix in #5799!

@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch 6 times, most recently from 824e702 to bbc9d94 Compare April 26, 2026 20:22
@elicsmit elicsmit closed this Apr 26, 2026
@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch from bbc9d94 to 5dda254 Compare April 26, 2026 20:23
@elicsmit elicsmit reopened this Apr 26, 2026
@elicsmit elicsmit closed this Apr 27, 2026
@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch from 91b0286 to 21ca05f Compare April 27, 2026 11:50
@elicsmit elicsmit reopened this Apr 27, 2026
@elicsmit elicsmit force-pushed the fix-swagger-tags-journal branch from 2cd6d3f to 791ca67 Compare April 27, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants