Skip to content

fix: make service ports configurable #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 1 commit into from
Aug 21, 2026
Merged

fix: make service ports configurable #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions HelmSetup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
| mysql.securityContext | pod security context values | {} |
| mysql.containerSecurityContext | container security context values | {} |
| mysql.service.type | mysql service type | ClusterIP |
| mysql.service.port | port exposed by the internal mysql service | 3306 |
| mysql.service.nodePort | specify mysql nodeport | "" |
| grafana | dashboard, datasource, etc. settings for grafana, installed by grafana official chart | |
| lake.replicaCount | Replica count can only be 0 or 1 | 1 |
Expand Down Expand Up @@ -200,6 +201,7 @@ Some useful parameters for the chart, you could also check them in values.yaml
| ui.livenessProbe | container livenessprobe | see Values.yaml |
| ui.readinessProbe | container readinessProbe | see Values.yaml |
| ui.deployment.extraLabels | extra labels for ui's deployment metadata | {} |
| ui.service.port | port exposed by the ui service; the container still listens on port 4000 | 4000 |
| service.type | Service type for exposed service | NodePort |
| service.uiPort | Node port for config ui | 32001 |
| ingress.enabled | If enable ingress | false |
Expand Down
2 changes: 1 addition & 1 deletion charts/devlake/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ The mysql port
{{- if .Values.mysql.useExternal }}
{{- .Values.mysql.externalPort }}
{{- else }}
{{- 3306 }}
{{- .Values.mysql.service.port }}
{{- end }}
{{- end }}

Expand Down
11 changes: 6 additions & 5 deletions charts/devlake/templates/deployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ spec:
{{- end }}
imagePullPolicy: {{ .Values.ui.image.pullPolicy }}
ports:
- containerPort: 4000
- name: ui
containerPort: 4000
{{- with .Values.ui.livenessProbe }}
livenessProbe:
{{- toYaml . | nindent 12 }}
Expand All @@ -86,15 +87,15 @@ spec:
{{- end }}
env:
- name: DEVLAKE_ENDPOINT
value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080
value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}

@TOGEP TOGEP Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lake.port was introduced in #144, but this endpoint continued to use the hard-coded port 8080

{{- if not .Values.grafana.enabled }}
- name: GRAFANA_ENDPOINT
value: {{ .Values.grafana.external.url }}
- name: USE_EXTERNAL_GRAFANA
value: "true"
{{- else }}
- name: GRAFANA_ENDPOINT
value: {{ .Release.Name }}-grafana.{{ .Release.Namespace }}.svc.cluster.local:80
value: {{ .Release.Name }}-grafana.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.grafana.service.port }}
{{- end }}
{{- range $key, $value := .Values.commonEnvs }}
- name: "{{ tpl $key $ }}"
Expand Down Expand Up @@ -183,7 +184,8 @@ spec:
{{- end }}
imagePullPolicy: {{ .Values.lake.image.pullPolicy }}
ports:
- containerPort: {{ .Values.lake.port }}
- name: lake
containerPort: {{ .Values.lake.port }}
{{- with .Values.lake.livenessProbe }}
livenessProbe:
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -255,4 +257,3 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}


8 changes: 4 additions & 4 deletions charts/devlake/templates/ingresses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ spec:
service:
name: {{ $uiServiceName }}
port:
number: 4000
number: {{ .Values.ui.service.port }}
{{- else }}
serviceName: {{ $uiServiceName }}
servicePort: 4000
servicePort: {{ .Values.ui.service.port }}
{{- end }}
{{- if .Values.ingress.extraPaths }}
{{- toYaml .Values.ingress.extraPaths | nindent 10 }}
Expand Down Expand Up @@ -133,10 +133,10 @@ spec:
service:
name: {{ $uiServiceName }}
port:
number: 4000
number: {{ .Values.ui.service.port }}
{{- else }}
serviceName: {{ $uiServiceName }}
servicePort: 4000
servicePort: {{ .Values.ui.service.port }}
{{- end }}
{{- end }}
{{- end }}
10 changes: 5 additions & 5 deletions charts/devlake/templates/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ spec:
ports:
- protocol: TCP
name: mysql
port: 3306
targetPort: 3306
port: {{ .Values.mysql.service.port }}
targetPort: mysql
{{- if and (eq .Values.mysql.service.type "NodePort") .Values.mysql.service.nodePort }}
nodePort: {{ .Values.mysql.service.nodePort }}
{{- end }}
Expand All @@ -65,7 +65,7 @@ spec:
- protocol: TCP
name: devlake
port: {{ .Values.lake.port }}
targetPort: {{ .Values.lake.port }}
targetPort: lake

---
# ui
Expand All @@ -86,8 +86,8 @@ spec:
ports:
- protocol: TCP
name: ui
port: 4000
targetPort: 4000
port: {{ .Values.ui.service.port }}
targetPort: ui
{{- if eq .Values.service.type "NodePort" }}
nodePort: {{ .Values.service.uiPort }}
{{- end }}
12 changes: 8 additions & 4 deletions charts/devlake/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ mysql:

service:
type: "ClusterIP"
# Port exposed by the in-cluster MySQL service.
port: 3306
nodePort: ""
loadBalancerIP: ""
extraLabels: {}
Expand Down Expand Up @@ -224,7 +226,7 @@ lake:
livenessProbe:
httpGet:
path: /ping
port: 8080
port: lake
scheme: HTTP
failureThreshold: 5
initialDelaySeconds: 30
Expand All @@ -235,7 +237,7 @@ lake:
readinessProbe:
httpGet:
path: /ping
port: 8080
port: lake
scheme: HTTP
failureThreshold: 3
initialDelaySeconds: 5
Expand Down Expand Up @@ -290,7 +292,7 @@ ui:
livenessProbe:
httpGet:
path: /health/
port: 4000
port: ui
scheme: HTTP
failureThreshold: 5
initialDelaySeconds: 15
Expand All @@ -301,7 +303,7 @@ ui:
readinessProbe:
httpGet:
path: /health/
port: 4000
port: ui
scheme: HTTP
failureThreshold: 3
initialDelaySeconds: 5
Expand Down Expand Up @@ -343,6 +345,8 @@ ui:
extraLabels: {}

service:
# Port exposed by the UI service. The UI container listens on port 4000.
port: 4000
extraLabels: {}

## Side Contaainer Configuration
Expand Down
Loading