Skip to content

fix: make service ports configurable - #380

Merged
klesh merged 1 commit into
apache:mainfrom
TOGEP:fix/configurable-ports
Aug 21, 2026
Merged

fix: make service ports configurable#380
klesh merged 1 commit into
apache:mainfrom
TOGEP:fix/configurable-ports

Conversation

@TOGEP

@TOGEP TOGEP commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Make the MySQL and UI Service ports configurable through values.yaml
Also replace hard-coded ports in the Lake and Grafana endpoints with their existing configured values.
Fixes #372

Changes

  • Add mysql.service.port (default: 3306)
  • Add ui.service.port (default: 4000)
  • Document the new values in HelmSetup.md

The default values remain unchanged, so existing installations are not affected.

env:
- name: DEVLAKE_ENDPOINT
value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080
value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}

@TOGEP TOGEP Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lake.port was introduced in #144, but this endpoint continued to use the hard-coded port 8080

@TOGEP

TOGEP commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

🤔

https://github.com/apache/devlake-helm-chart/actions/runs/32338299965/job/96645343915#step:2:39

  /usr/local/bin/kind: line 1: !DOCTYPE: No such file or directory
  /usr/local/bin/kind: line 2: !--
  /usr/local/bin/kind: line 4: Hello: command not found
  /usr/local/bin/kind: line 7: unexpected EOF while looking for matching `''

@TOGEP

TOGEP commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

The mysql-external job failed while downloading the kind binary and appears to be a transient CI issue.
The parallel mysql-builtin job completed successfully

I do not have permission to re-run the failed job. Could a maintainer please re-run it?

@klesh klesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution.

@klesh
klesh merged commit b9553bc into apache:main Aug 21, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ports to values.yaml

2 participants