fix: make service ports configurable - #380
Merged
Merged
Conversation
TOGEP
commented
Aug 20, 2026
| env: | ||
| - name: DEVLAKE_ENDPOINT | ||
| value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:8080 | ||
| value: {{ include "devlake.fullname" . }}-lake.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }} |
Contributor
Author
There was a problem hiding this comment.
lake.port was introduced in #144, but this endpoint continued to use the hard-coded port 8080
Contributor
Author
|
🤔 https://github.com/apache/devlake-helm-chart/actions/runs/32338299965/job/96645343915#step:2:39 |
Contributor
Author
|
The I do not have permission to re-run the failed job. Could a maintainer please re-run it? |
klesh
approved these changes
Aug 21, 2026
klesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the MySQL and UI Service ports configurable through
values.yamlAlso replace hard-coded ports in the Lake and Grafana endpoints with their existing configured values.
Fixes #372
Changes
mysql.service.port(default:3306)ui.service.port(default:4000)HelmSetup.mdThe default values remain unchanged, so existing installations are not affected.