Skip to content

MINOR: [C++][IPC] Avoid int64 overflow in ReadSparseCSXIndex #50038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmestwa-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −8
Open

MINOR: [C++][IPC] Avoid int64 overflow in ReadSparseCSXIndex #50038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions cpp/src/arrow/ipc/reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ namespace flatbuf = org::apache::arrow::flatbuf;
using internal::AddWithOverflow;
using internal::checked_cast;
using internal::checked_pointer_cast;
using internal::MultiplyWithOverflow;

namespace ipc {

Expand Down Expand Up @@ -2336,26 +2337,40 @@ Result<std::shared_ptr<SparseIndex>> ReadSparseCSXIndex(
/*allow_short_read=*/false));

std::vector<int64_t> indices_shape({non_zero_length});
const auto indices_minimum_bytes = indices_shape[0] * indices_type->byte_width();
if (indices_minimum_bytes > indices_buffer->length()) {
const auto indices_minimum_bytes =
MultiplyWithOverflow<int64_t>({indices_shape[0], indices_type->byte_width()});
if (!indices_minimum_bytes.has_value() ||
indices_minimum_bytes.value() > indices_buffer->length()) {
return Status::Invalid("shape is inconsistent to the size of indices buffer");
}

switch (sparse_index->compressedAxis()) {
case flatbuf::SparseMatrixCompressedAxis::SparseMatrixCompressedAxis_Row: {
std::vector<int64_t> indptr_shape({shape[0] + 1});
const int64_t indptr_minimum_bytes = indptr_shape[0] * indptr_byte_width;
if (indptr_minimum_bytes > indptr_buffer->length()) {
const auto indptr_length = AddWithOverflow<int64_t>({shape[0], 1});
if (!indptr_length.has_value()) {
return Status::Invalid("shape is inconsistent to the size of indptr buffer");
}
std::vector<int64_t> indptr_shape({indptr_length.value()});
const auto indptr_minimum_bytes =
MultiplyWithOverflow<int64_t>({indptr_shape[0], indptr_byte_width});
if (!indptr_minimum_bytes.has_value() ||
indptr_minimum_bytes.value() > indptr_buffer->length()) {
return Status::Invalid("shape is inconsistent to the size of indptr buffer");
}
return std::make_shared<SparseCSRIndex>(
std::make_shared<Tensor>(indptr_type, indptr_data, indptr_shape),
std::make_shared<Tensor>(indices_type, indices_data, indices_shape));
}
case flatbuf::SparseMatrixCompressedAxis::SparseMatrixCompressedAxis_Column: {
std::vector<int64_t> indptr_shape({shape[1] + 1});
const int64_t indptr_minimum_bytes = indptr_shape[0] * indptr_byte_width;
if (indptr_minimum_bytes > indptr_buffer->length()) {
const auto indptr_length = AddWithOverflow<int64_t>({shape[1], 1});
if (!indptr_length.has_value()) {
return Status::Invalid("shape is inconsistent to the size of indptr buffer");
}
std::vector<int64_t> indptr_shape({indptr_length.value()});
const auto indptr_minimum_bytes =
MultiplyWithOverflow<int64_t>({indptr_shape[0], indptr_byte_width});
if (!indptr_minimum_bytes.has_value() ||
indptr_minimum_bytes.value() > indptr_buffer->length()) {
return Status::Invalid("shape is inconsistent to the size of indptr buffer");
}
return std::make_shared<SparseCSCIndex>(
Expand Down