MINOR: [C++][IPC] Avoid int64 overflow in ReadSparseCSXIndex#50038
Open
jmestwa-coder wants to merge 1 commit into
Open
MINOR: [C++][IPC] Avoid int64 overflow in ReadSparseCSXIndex#50038jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadSparseCSXIndex sizes its indices/indptr buffer checks with
non_zero_length * byte_widthand(shape + 1) * byte_widthin int64, but both come straight from the SparseTensor flatbuffer via GetSparseTensorMetadata. A non_zero_length near INT64_MAX wraps the product, so the size guard passes and the index Tensor is built over a buffer smaller than its shape. Use the checked helpers from tensor.cc.