TODO Cleanup - #6509
Open
Amemeda wants to merge 5 commits into
Open
Conversation
Amemeda
changed the title
Amemeda
commented
Aug 20, 2026
Comment on lines
+80
to
+91
| /* | ||
| * TODO ACCUMULO-2938 redact key extents in this output to avoid leaking protected | ||
| * information. | ||
| */ | ||
|
|
||
| // convert each tabletId in migrations to keyExtent | ||
| Set<KeyExtent> keyExtents = migrations.stream().map(tabletId -> { | ||
| KeyExtent extent = KeyExtent.fromTabletId(tabletId); | ||
| extent.obscured(); | ||
| return extent; | ||
| }).collect(Collectors.toSet()); | ||
|
|
||
| if (log.isDebugEnabled()) { | ||
| log.debug("Sample up to 10 outstanding migrations: {}", | ||
| migrations.stream().limit(10).map(String::valueOf).collect(Collectors.joining(", "))); | ||
| keyExtents.stream().limit(10).map(String::valueOf).collect(Collectors.joining(", "))); |
Contributor
Author
There was a problem hiding this comment.
Adding these comments from the ASF accumulo channel
DomGarguilo
reviewed
Aug 21, 2026
DomGarguilo
reviewed
Aug 21, 2026
Contributor
Author
if (retryCountDownTimer.isExpired()) {
// TODO exception used for timeout is inconsistent
throw new TimedOutException(
"Failed to find servers to process scans before timeout was exceeded.");
}Does anyone know why this exception from |
dlmarion
reviewed
Aug 21, 2026
Contributor
No idea |
Amemeda
commented
Aug 24, 2026
Comment on lines
307
to
310
| if (retryCountDownTimer.isExpired()) { | ||
| // TODO exception used for timeout is inconsistent | ||
| throw new TimedOutException( | ||
| "Failed to find servers to process scans before timeout was exceeded."); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Removed this TODO for now. The exception used here seems consistent with what is happening: TimedOutException because the retryCountDownTimer has expired. If anything, the message may not be accurate description of why the timeout happened.
I can add it back if the todo should remain, or if a different exception/message should be used here, I can replace.
Amemeda
commented
Aug 25, 2026
Comment on lines
336
to
339
| zkLockChecker = memoize(() -> { | ||
| // make this use its own ZooSession and ZooCache, because this is used by the | ||
| // tablet location cache, which is a static singleton reused by multiple clients | ||
| // so, it can't rely on being able to continue to use the same client's ZooCache, | ||
| // because that client could be closed, and its ZooSession also closed | ||
| // this needs to be fixed; TODO https://github.com/apache/accumulo/issues/2301 | ||
| var zk = info.getZooKeeperSupplier(ZookeeperLockChecker.class.getSimpleName(), | ||
| ZooUtil.getRoot(getInstanceID())).get(); | ||
| return new ZookeeperLockChecker(new ZooCache(zk, Set.of(Constants.ZTSERVERS))); |
Contributor
Author
There was a problem hiding this comment.
Attaching comment from issue discussing the relevance of this TODO. It looks like it is no longer relevant but could use Christopher's opinion.
#2699 (comment)
Amemeda
marked this pull request as ready for review
August 25, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThrottledBalancerProblemReporter.java. Added this logic onto existing .stream in the logger that logs 10 outstanding migrations.ClientContext.java.TabletServerBatchReaderIterator.java, the exception used here does not seem inconsistent since the retryCountDownTimer expired.Removes 3 TODOs from #2699