Skip to content

test(core): simplify provider smoke tests - #45656

Merged
kitlangton merged 3 commits into
v2from
provider-smoke-tests
Aug 28, 2026
Merged

test(core): simplify provider smoke tests#45656
kitlangton merged 3 commits into
v2from
provider-smoke-tests

Conversation

@kitlangton

@kitlangton kitlangton commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why
Several provider registration checks were synchronous assertions wrapped in the full Effect plugin harness. Nearby provider suites also retained unused service acquisitions, same-instance provisioning, nested service reads, or import aliases that did not contribute to their scenarios.

What Changes

  • Registers the Kilo, LLMGateway, NVIDIA, OpenRouter, Zenmux, and LM Studio catalog-membership assertions as ordinary Bun tests.
  • Keeps hook, catalog, integration, discovery, and local-server behavior cases on the existing Effect harness.
  • Removes dead Plugin/AISDK acquisitions from Dynamic, Vercel, and GitHub Copilot cases.
  • Calls LLMGateway and OpenAI plugins with their ambient Integration services instead of fetching and re-providing the same instance.
  • Binds GitHub Copilot and OpenAI Integration/PluginHooks services before invoking their methods.
  • Uses convertToOpenAICompatibleChatMessages directly throughout its converter suite.

Scope
This changes test setup only. Provider registration contents, plugin behavior, local discovery, historical compatibility assertions, and converter expectations are unchanged. OpenAI catalog behavior remains owned by #45336, GitHub Copilot title behavior by #43794, and LM Studio reasoning behavior by #43076.

Verification

cd packages/core
bun run test test/plugin/provider-kilo.test.ts test/plugin/provider-llmgateway.test.ts test/plugin/provider-nvidia.test.ts test/plugin/provider-openrouter.test.ts test/plugin/provider-zenmux.test.ts test/plugin/provider-vercel.test.ts test/plugin/provider-dynamic.test.ts test/github-copilot/convert-to-copilot-messages.test.ts
bun run test test/plugin/provider-lmstudio.test.ts test/plugin/provider-github-copilot.test.ts test/plugin/provider-openai.test.ts
bun typecheck

cd ../..
bun turbo typecheck --concurrency=3
bun prettier --check packages/core/test/plugin/provider-kilo.test.ts packages/core/test/plugin/provider-llmgateway.test.ts packages/core/test/plugin/provider-nvidia.test.ts packages/core/test/plugin/provider-openrouter.test.ts packages/core/test/plugin/provider-zenmux.test.ts packages/core/test/plugin/provider-vercel.test.ts packages/core/test/plugin/provider-dynamic.test.ts packages/core/test/github-copilot/convert-to-copilot-messages.test.ts packages/core/test/plugin/provider-lmstudio.test.ts packages/core/test/plugin/provider-github-copilot.test.ts packages/core/test/plugin/provider-openai.test.ts
git diff --check origin/v2...HEAD

50 original focused tests and 27 continuation tests passed. Core and push-hook workspace typechecks passed. Formatting and diff checks passed; scoped lint reported zero errors with pre-existing fixture assertion warnings only.

@kitlangton
kitlangton merged commit ac3cd1b into v2 Aug 28, 2026
8 checks passed
@kitlangton
kitlangton deleted the provider-smoke-tests branch August 28, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant