test(core): simplify provider smoke tests - #45656
Merged
Merged
Conversation
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several provider registration checks were synchronous assertions wrapped in the full Effect plugin harness. Nearby provider suites also retained unused service acquisitions, same-instance provisioning, nested service reads, or import aliases that did not contribute to their scenarios.
What Changes
convertToOpenAICompatibleChatMessagesdirectly throughout its converter suite.Scope
This changes test setup only. Provider registration contents, plugin behavior, local discovery, historical compatibility assertions, and converter expectations are unchanged. OpenAI catalog behavior remains owned by #45336, GitHub Copilot title behavior by #43794, and LM Studio reasoning behavior by #43076.
Verification
50 original focused tests and 27 continuation tests passed. Core and push-hook workspace typechecks passed. Formatting and diff checks passed; scoped lint reported zero errors with pre-existing fixture assertion warnings only.