test(core): simplify provider test fixtures - #45743
Merged
Merged
Conversation
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Provider tests still provisioned services they never consumed and constructed complete catalog records only to copy a few fields into the real draft. Canonical-binding tests also retained nested service reads and renamed imports, obscuring the actual test boundary.
What Changes
testexport in the Snowflake transport cases and the canonical test-host export in Promise adapter cases.Scope
This owns the still-unowned TESTP-04, TESTP-06, and TESTP-08 occurrences in these eight files. #45635, #45656, #45669, #45689, and #45721 own the other accepted occurrences; only
provider-openai.test.tsoverlaps #45656 at the file level, with this PR changing catalog setup while #45656 changes activation/integration binding, so there is no dependency. Selector sentinels and Vertex transport injection remain separate follow-ups. Test-only refactoring requires no changeset.Verification
All 88 focused tests passed. Core and push-hook workspace typechecks passed. Formatting and diff checks passed. Scoped lint reported zero errors and only 13 pre-existing fixture assertion/control-flow warnings.