refactor(app): give full-screen settings a dedicated route - #45365
Open
Brendonovich wants to merge 3 commits into
Open
refactor(app): give full-screen settings a dedicated route#45365Brendonovich wants to merge 3 commits into
Brendonovich wants to merge 3 commits into
Conversation
# Conflicts: # packages/app/e2e/regression/remote-session-settings.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/settingsinstead of hiding the current route behind a separate surface.Stack
Follow-up to #45361. This PR targets
settings-tab-focus; merge the focus fix first, then retarget this PR tov2. Includes the latest focus-fix branch and its draft new-tab regression coverage.Recording
Session -> settings -> Models -> reload retaining remote context -> Back -> Forward -> Back -> settings -> same-tab return. Recorded from
7d19d78601using the committed mocked regression test, with temporary Playwright slow motion for readability. Viewport and recording: 1280x720; duration: 11.96 seconds. Later history-command and new-tab fixes are covered by the regression tests below.video.webm
Validation
bun typecheck; appbun run typecheck:e2e