Skip to content

fix(app): clear active tab while settings is open - #45361

Open
Brendonovich wants to merge 3 commits into
v2from
settings-tab-focus
Open

fix(app): clear active tab while settings is open#45361
Brendonovich wants to merge 3 commits into
v2from
settings-tab-focus

Conversation

@Brendonovich

@Brendonovich Brendonovich commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Clear the active session/draft tab while full-screen settings is open, for both horizontal and vertical tabs.
  • Keep tab memory unchanged and let clicking the underlying tab return to the app.
  • Add regression coverage for opening settings, returning to the app, and selecting the same tab.

Before / After

Settings open over the deterministic remote session from packages/app/e2e/regression/remote-session-settings.spec.ts. Before: fedf017e25 (v2 at capture). After: fdd8abc9df. Identical Chromium, dark theme, fixture data, route, and viewport within each pair. The session tab is no longer highlighted while settings is open.

Layout Before After
Horizontal, 1280x720 Before: horizontal session tab remains active over settings After: horizontal session tab is inactive over settings
Vertical, 1280x720 Before: vertical session tab remains active over settings After: vertical session tab is inactive over settings
Mobile, 390x844 Before: mobile session tab remains active over settings After: mobile session tab is inactive over settings

Vertical and mobile captures set settings.v3.appearance.tabLayout to vertical; mobile correctly uses the horizontal fallback. The dev-only badge is hidden for captures. These images cover fdd8abc9df, not later follow-up commits.

Validation

  • bun typecheck in packages/app
  • PLAYWRIGHT_PORT=4573 bun run test:e2e e2e/regression/remote-session-settings.spec.ts --grep "session settings use" (1 passed)
  • Pre-push workspace typecheck (32 packages passed)
  • Isolated screenshot checks at fdd8abc9df: horizontal, vertical, and mobile passed (3/3); confirmed inactive tabs while settings is open, unchanged persisted tab list, and restoration via both Back to app and clicking the same session tab. Base captures reproduced the active-tab issue (3/3). The existing remote-session settings regression also passed on port 4575 (1/1).

Follow-up

A separate PR will make full-screen settings a dedicated route and remove the settings-specific tab matching guard.

@Brendonovich
Brendonovich requested a review from Hona as a code owner August 26, 2026 18:37
@Brendonovich

Copy link
Copy Markdown
Member Author

Follow-up: #45365 makes full-screen settings a dedicated route and removes the settings-specific tab matching guard. It is stacked on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant