fix(app): clear active tab while settings is open - #45361
Open
Brendonovich wants to merge 3 commits into
Open
Conversation
Member
Author
|
Follow-up: #45365 makes full-screen settings a dedicated route and removes the settings-specific tab matching guard. It is stacked on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before / After
Settings open over the deterministic remote session from
packages/app/e2e/regression/remote-session-settings.spec.ts. Before:fedf017e25(v2at capture). After:fdd8abc9df. Identical Chromium, dark theme, fixture data, route, and viewport within each pair. The session tab is no longer highlighted while settings is open.Vertical and mobile captures set
settings.v3.appearance.tabLayouttovertical; mobile correctly uses the horizontal fallback. The dev-only badge is hidden for captures. These images coverfdd8abc9df, not later follow-up commits.Validation
bun typecheckinpackages/appPLAYWRIGHT_PORT=4573 bun run test:e2e e2e/regression/remote-session-settings.spec.ts --grep "session settings use"(1 passed)fdd8abc9df: horizontal, vertical, and mobile passed (3/3); confirmed inactive tabs while settings is open, unchanged persisted tab list, and restoration via both Back to app and clicking the same session tab. Base captures reproduced the active-tab issue (3/3). The existing remote-session settings regression also passed on port 4575 (1/1).Follow-up
A separate PR will make full-screen settings a dedicated route and remove the settings-specific tab matching guard.