Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/tool/plugin/subagent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const Plugin = {
.pipe(Effect.mapError((error) => new ToolFailure({ message: `Subagent denied: ${agent.id}`, error })))

const existing =
input.sessionID === undefined
input.sessionID === undefined || input.sessionID === context.sessionID
? undefined
: yield* runtime.session
.get(input.sessionID)
Expand Down
33 changes: 33 additions & 0 deletions packages/core/test/tool-subagent.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,39 @@ describe("SubagentTool", () => {
),
)

it.live("treats the current session ID as a new subagent request", () =>
Effect.acquireRelease(
Effect.promise(() => tmpdir()),
(dir) => Effect.promise(() => dir[Symbol.asyncDispose]()),
).pipe(
Effect.flatMap((dir) =>
Effect.gen(function* () {
const location = Location.Ref.make({ directory: AbsolutePath.make(dir.path) })
const sessions = yield* Session.Service
const parent = yield* sessions.create({ location, model: parentModel })
yield* withSubagent(parent.location)
const locations = yield* LocationServiceMap.Service
const registry = yield* Tool.Service.pipe(Effect.provide(locations.get(parent.location)))

const result = yield* executeTool(registry, {
sessionID: parent.id,
...toolIdentity,
call: {
type: "tool-call",
id: "call-self-session",
name: SubagentTool.name,
input: { agent: "reviewer", description: "review", prompt: "review this", sessionID: parent.id },
},
})
const childID = outputSessionID(result.metadata)

expect(childID).not.toBe(parent.id)
expect((yield* sessions.get(childID)).parentID).toBe(parent.id)
}),
),
),
)

it.live("steers a running child session in the background", () =>
Effect.acquireRelease(
Effect.promise(() => tmpdir()),
Expand Down
Loading