fix(core): ignore self-referential subagent IDs - #45362
Open
mjnaderi wants to merge 2 commits into
Open
Conversation
Some models echo the calling session ID as the subagent sessionID while requesting a new delegation. The continuation ownership check then rejects the caller as a non-child. Treat a self-referential sessionID as absent so the call creates a new child session. Keep direct-child continuation and unrelated-session rejection unchanged.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
mjnaderi
force-pushed
the
self-subagent-id
branch
from
August 26, 2026 19:49
abb7ce2 to
e7c8e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #45364
Type of change
What does this PR do?
Some models echo the calling session ID as
subagent.sessionIDwhile requesting a new delegation. The continuation ownership check rejects that ID because a session is not its own child.Treat a self-referential
sessionIDas absent so the request creates a new child. Existing direct-child continuation and unrelated-session rejection are unchanged.How did you verify your code works?
bun test test/tool-subagent.test.tsfrompackages/corebun typecheckfrompackages/coreScreenshots / recordings
Not applicable; this is a Core behavior change.
Checklist