Skip to content

Fix double-increment of progress bar position in DebuggedProgressBar.make_step #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xsuchy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix double-increment of progress bar position in DebuggedProgressBar.make_step #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/commoncode/cliutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,8 @@ class DebuggedProgressBar(CompatProgressBar):
# overriden and copied from Click to work around Click woes for
# https://github.com/aboutcode-org/scancode-toolkit/issues/2583
def make_step(self, n_steps):
# always increment
self.pos += n_steps or 1
super(DebuggedProgressBar, self).make_step(n_steps)
# always increment even if n_steps is 0
super(DebuggedProgressBar, self).make_step(n_steps or 1)

# overriden and copied from Click to work around Click woes for
# https://github.com/aboutcode-org/scancode-toolkit/issues/2583
Expand Down