Fix double-increment of progress bar position in DebuggedProgressBar.make_step#100
Open
xsuchy wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Fix double-increment of progress bar position in DebuggedProgressBar.make_step#100xsuchy wants to merge 1 commit intoaboutcode-org:mainfrom
xsuchy wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
…make_step make_step was incrementing self.pos manually and then calling super().make_step() which incremented it again, causing the progress bar to advance twice as fast as expected. Related to: aboutcode-org/scancode-toolkit#4100 Signed-off-by: Miroslav Suchý <msuchy@redhat.com> Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_step was incrementing self.pos manually and then calling super().make_step() which incremented it again, causing the progress bar to advance twice as fast as expected.
Related to: aboutcode-org/scancode-toolkit#4100
Assisted-By: Claude Opus 4.6 noreply@anthropic.com