Skip to content

Admin: Standardize theme install overlay button height in mobile #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshupathak95 wants to merge 3 commits into
base: trunk
Choose a base branch
from
+6 −8
Open

Admin: Standardize theme install overlay button height in mobile #11497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2878134
Administration: Standardize theme install overlay button height in mo…
himanshupathak95 Apr 9, 2026
13bcff3
Fix: Adjust theme install overlay button height and line spacing for …
himanshupathak95 Apr 10, 2026
fedc97b
Admin: Use button-compact for theme install overlay header buttons
himanshupathak95 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/wp-admin/css/themes.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,7 @@ body.full-overlay-active {

.theme-install-overlay .wp-full-overlay-header .button {
float: right;
margin: 3px 10px 0 0; /* Vertically center 40px button in 45px header */
margin: 7px 10px 0 0; /* Vertically center 40px button in 45px header */
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: 7px 10px 0 0; /* Vertically center 40px button in 45px header */
margin: 7px 10px 0 0; /* Vertically center 32px button in 45px header */

}

.theme-install-overlay .wp-full-overlay-sidebar {
Expand Down Expand Up @@ -2053,8 +2053,6 @@ body.full-overlay-active {

.theme-install-overlay .wp-full-overlay-header .button {
font-size: 13px;
line-height: 2.15384615;
min-height: 30px;
}

.theme-browser .theme .theme-actions .button {
Expand Down
10 changes: 5 additions & 5 deletions src/wp-admin/theme-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,18 +487,18 @@
$aria_label = sprintf( _x( 'Activate %s', 'theme' ), '{{ data.name }}' );
?>
<# if ( ! data.active ) { #>
<a class="button button-primary activate" href="{{ data.activate_url }}" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Activate' ); ?></a>
<a class="button button-primary button-compact activate" href="{{ data.activate_url }}" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Activate' ); ?></a>
<# } else { #>
<button class="button button-primary disabled"><?php _ex( 'Activated', 'theme' ); ?></button>
<button class="button button-primary button-compact disabled"><?php _ex( 'Activated', 'theme' ); ?></button>
<# } #>
<# } else { #>
<a class="button button-primary disabled" ><?php _ex( 'Cannot Activate', 'theme' ); ?></a>
<a class="button button-primary button-compact disabled" ><?php _ex( 'Cannot Activate', 'theme' ); ?></a>
<# } #>
<# } else { #>
<# if ( data.compatible_wp && data.compatible_php ) { #>
<a href="{{ data.install_url }}" class="button button-primary theme-install" data-name="{{ data.name }}" data-slug="{{ data.id }}"><?php _e( 'Install' ); ?></a>
<a href="{{ data.install_url }}" class="button button-primary button-compact theme-install" data-name="{{ data.name }}" data-slug="{{ data.id }}"><?php _e( 'Install' ); ?></a>
<# } else { #>
<a class="button button-primary disabled" ><?php _ex( 'Cannot Install', 'theme' ); ?></a>
<a class="button button-primary button-compact disabled" ><?php _ex( 'Cannot Install', 'theme' ); ?></a>
<# } #>
<# } #>
</div>
Expand Down
Loading