Skip to content

Admin: Standardize theme install overlay button height in mobile#11497

Open
himanshupathak95 wants to merge 2 commits intoWordPress:trunkfrom
himanshupathak95:fix/64999-themes-overlay-mobile-element-height
Open

Admin: Standardize theme install overlay button height in mobile#11497
himanshupathak95 wants to merge 2 commits intoWordPress:trunkfrom
himanshupathak95:fix/64999-themes-overlay-mobile-element-height

Conversation

@himanshupathak95
Copy link
Copy Markdown

@himanshupathak95 himanshupathak95 commented Apr 9, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64999

Fixes .theme-install-overlay .wp-full-overlay-header .button to use the standard mobile button size in mobile views (≤782px), replacing the non-standard 30px/13px values.

Before After
Before Screenshot image

@himanshupathak95 himanshupathak95 force-pushed the fix/64999-themes-overlay-mobile-element-height branch from 2552518 to 6acd2ba Compare April 9, 2026 06:13
@himanshupathak95 himanshupathak95 marked this pull request as ready for review April 9, 2026 06:15
@himanshupathak95 himanshupathak95 changed the title Administration: Standardize theme install overlay button height in mobile Admin: Standardize theme install overlay button height in mobile Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Personally, I think it might be better to standardize on the 32px size.

See:

@himanshupathak95 himanshupathak95 force-pushed the fix/64999-themes-overlay-mobile-element-height branch from 6acd2ba to 954f6c9 Compare April 10, 2026 05:28
@himanshupathak95
Copy link
Copy Markdown
Author

Thanks for the PR. Personally, I think it might be better to standardize on the 32px size.

Thanks for looking into this. 32px does look more mobile-centric. Incorporated in 954f6c9

@t-hamano
Copy link
Copy Markdown
Contributor

Thanks for the update! However, I personally suggest the following two changes.

  • I propose changing the button height to 32px for non-mobile viewports as well. The 40px button size feels too large for the customizer header.
  • Use the new button-compact class: This should eliminate the need to hard-code various styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants