Admin: Standardize theme install overlay button height in mobile#11497
Admin: Standardize theme install overlay button height in mobile#11497himanshupathak95 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
2552518 to
6acd2ba
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR. Personally, I think it might be better to standardize on the 32px size.
See:
6acd2ba to
954f6c9
Compare
Thanks for looking into this. 32px does look more mobile-centric. Incorporated in 954f6c9 |
|
Thanks for the update! However, I personally suggest the following two changes.
|
Trac ticket: https://core.trac.wordpress.org/ticket/64999
Fixes
.theme-install-overlay .wp-full-overlay-header .buttonto use the standard mobile button size in mobile views (≤782px), replacing the non-standard 30px/13px values.