fix(vtable): avoid frozen row height duplication - #5255
Open
fangsmile wants to merge 13 commits into
Open
Conversation
…zen-row-gap # Conflicts: # packages/vtable/examples/menu.ts
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n- Fix table height calculation when top frozen rows include body rows and bottom frozen rows are also configured.\n- Add a minimal debug demo for issue #4904.\n\n### Why\nWhen
frozenRowCountis greater than the column header level, frozen body rows are moved into the header area, but the previous scenegraph group-height based table height calculation could count those rows again throughbodyGroup.height. This produced a blank gap before the bottom frozen rows.\n\n### Verification\n- Reproduced withfrozenRowCount: 5,bottomFrozenRowCount: 2, 10 records, 800x800 container.\n- Verified the gap is removed after the fix.\n- Added bugserver case: https://bugserver.cn.goofy.app/case?product=VTable&fileid=6a69f6177406d0005d72f226\n\n### Related\n- Closes #4904