fix: align frozen rows in short tables - #5254
Closed
biubiukam wants to merge 1 commit into
Closed
Conversation
Contributor
|
#5255 已经解决。后续修复问题提pr, 请补充相关复现demo到项目examples中 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤔 This is a ...
🔗 Related issue link
fix #5253
💡 Background and solution
When table content is shorter than the viewport, combining top and bottom frozen rows can inflate the scenegraph content height and place the bottom frozen row below the actual content.
The body scene container already includes the top frozen-row offset, but
updateTableSize()added the top, body, and bottom scene-container heights again. This counted the top frozen area twice.This change uses
getAllRowsHeight()as the canonical content height, keeping the table group, bottom frozen rows, and scrollbar metrics aligned. A regression test covers six records with four top frozen rows and one bottom frozen row. Before the fix, the table group height was 400 instead of 280; after the fix, the table group height is 280 and the bottom frozen group ends at the same content boundary.✅ Validation
scenegraph.ts.git diff --checkpassed.upstream/mainlookup warning.npm run compileremains blocked by four pre-existing errors insrc/state/checkbox/checkbox.ts(TS7006 and TS2339). This pull request does not modify that module.vtable-sheet, existing formula assertions, the video-cell test environment, and an existing checkbox record-index assertion. The focused frozen-row suites above pass, and this pull request only changes the scenegraph height calculation, its regression test, and the Rush change record.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough