layer: disable Xwayland bypass for some CatSystem2 engine games#2256
Open
matte-schwartz wants to merge 1 commit into
Open
layer: disable Xwayland bypass for some CatSystem2 engine games#2256matte-schwartz wants to merge 1 commit into
matte-schwartz wants to merge 1 commit into
Conversation
The Fruit of Grisaia and Himawari - The Sunflower - use D3D9 SWAPEFFECT_COPY partial presents. DXVK preserves the accumulated frame in its D3D9 backbuffer, but copies only the requested destination rectangle into each newly acquired Vulkan swapchain image. That works through the regular X11 presentation path, where partial updates accumulate in the persistent window drawable. With Xwayland bypass, however, the Vulkan frames are presented through a rotating Wayland swapchain whose untouched regions are not preserved. These games also mix in GDI drawing to the X window, splitting the final image between the X pixmap and the bypass surface. Whichever surface or swapchain image is presented last can leave the rest of the window stale. Sibling CatSystem2 titles enable the engine's render_always mode and present complete frames continuously, so they are unaffected. These two cannot: Grisaia's engine build (2.6.1.67) predates the flag, and Himawari ships with that config disabled with no clear way to enable it. Work around this by passing the layer through for the known-broken executables. Gate the remaining hooks on GamescopeInstance state so instances that were deliberately not taken over remain inert. Closes: ValveSoftware#2052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fruit of Grisaia and Himawari - The Sunflower - use D3D9 SWAPEFFECT_COPY partial presents. DXVK preserves the accumulated frame in its D3D9 backbuffer, but copies only the requested destination rectangle into each newly acquired Vulkan swapchain image.
That works through the regular X11 presentation path, where partial updates accumulate in the persistent window drawable. With Xwayland bypass, however, the Vulkan frames are presented through a rotating Wayland swapchain whose untouched regions are not preserved. These games also mix in GDI drawing to the X window, splitting the final image between the X pixmap and the bypass surface. Whichever surface or swapchain image is presented last can leave the rest of the window stale.
Sibling CatSystem2 titles enable the engine's render_always mode and present complete frames continuously, so they are unaffected. These two cannot: Grisaia's engine build (2.6.1.67) predates the flag, and Himawari ships with that config disabled with no clear way to enable it.
Work around this by passing the layer through for the known-broken executables. Gate the remaining hooks on GamescopeInstance state so instances that were deliberately not taken over remain inert.
Closes: #2052