bugfix(contain): Restore retail compatibility after changes to Object::m_containedByID

[Caball009]

• Follow-up PR for: bugfix(object): Avoid crash with dangling contain module in Object::onDestroy() when Reinforcement Pad is destroyed before Troop Crawler drop #2747

PR #2747 forgot to set the containedByID variable for objects that make use of the helix container code. This causes a mismatch in the following 5 replays: replays.zip

This PR adds the same code that was added to Object::onContainedBy to HelixContain::addToContain and HelixContain::addToContainList to fix the issue.

Resetting the contain variables, as is done in the third commit, is not needed to restore retail compatibility. I added that code because I think it's correct to reset the contain variables when the object is removed from its container.

TODO:

• Test against replays again.

[greptile-apps]

Greptile Summary

This PR restores retail-compatible containment state for Helix portable structures. The main changes are:

• Store the container ID when portable structures enter a Helix.
• Clear the stored container ID when they leave it.
• Preserve retail-compatible containment IDs during object serialization.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Include/GameLogic/Object.h	Declares containment setters used by the updated Helix flow.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Contain/HelixContain.cpp	Synchronizes portable Helix containment IDs during insertion and removal.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp	Keeps containment pointer bookkeeping and retail-compatible serialization behavior aligned.

_{Reviews (8): Last reviewed commit: "Tweaked older TSH comment." | Re-trigger Greptile}

[xezon]

This looks like it could change CRC, no?

[Caball009]

Yes, I've made some changes so I'm hopefully not introducing changes to the logic without a retail compatibility macro.

[Caball009]

I definitely need to run it against more replays, though.

[xezon]

Maybe do

void friend_setContainedBy( Object *containedBy )
{
  m_containedBy = containedBy;
  m_containedByFrame = m_containedBy ? TheGameLogic->getFrame() : 0;
}

This way the caller cannot set a wrong frame