fix(gameengine): Remove music tracks as prerequisite to initialize the game engine#2737
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/Common/GameAudio.h | Removes virtual isMusicAlreadyLoaded() declaration from AudioManager; no remaining references in the codebase. |
| Core/GameEngine/Source/Common/Audio/GameAudio.cpp | Removes the isMusicAlreadyLoaded() implementation that iterated audio events and checked for a music file on disk. |
| Generals/Code/GameEngine/Source/Common/GameEngine.cpp | Removes isMusicAlreadyLoaded() guard that called setQuitting(TRUE) when music files were absent. |
| GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp | Same isMusicAlreadyLoaded() guard removal as the Generals variant; symmetric and consistent. |
| Generals/Code/Tools/WorldBuilder/src/WorldBuilder.cpp | Removes early return FALSE when music files were absent in WorldBuilder init; initialization now proceeds without music. |
| GeneralsMD/Code/Tools/WorldBuilder/src/WorldBuilder.cpp | Same WorldBuilder early-return removal as the Generals variant; symmetric and consistent. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GameEngine::init / WorldBuilder::InitInstance] --> B[initSubsystem TheAudio]
B --> C{Before PR:\nisMusicAlreadyLoaded?}
C -- No --> D[setQuitting TRUE / return FALSE]
C -- Yes --> E[Continue initialization]
B --> F{After PR:\nNo check}
F --> E
E --> G[initSubsystem TheVideoPlayer, etc.]
G --> H[Game / WorldBuilder ready]
Reviews (2): Last reviewed commit: "Also fix World builder" | Re-trigger Greptile
|
This change also fixes the Replay Check. |
Caball009
left a comment
There was a problem hiding this comment.
Looks ok to me. Good to see the CI Replay checker working again.
This change removes music tracks as prerequisite to initialize the game engine. The game can now be started without the physical presence of music files. The game works normally, but without music.