refactor(network): Clean up utility functions for network commands

[Caball009]

• Related issue Replace more if / else chains with switch statements #1978

This PR cleans up some utility functions in the network code, mainly by refactoring them from if/else chains to switch statements. No change should have a functional difference.

See commits for cleaner (per function) diffs.

[greptile-apps]

Greptile Summary

This PR refactors four network utility functions in NetworkUtil.cpp from verbose if/else chains to cleaner switch statements, and adds const-correctness to two function signatures. No functional changes were intended, and verification confirms the enum value sets are identical before and after for each function.

• CommandRequiresAck is now a one-liner that delegates to DoesCommandRequireACommandID, eliminating a near-duplicate list that had a copy-paste duplicate (NETCOMMANDTYPE_DISCONNECTPLAYER) in the original.
• GetNetCommandTypeAsString gains a CASE_LABEL macro for DRY string expansion, adds three previously missing enum values (NETCOMMANDTYPE_UNKNOWN, NETCOMMANDTYPE_DISCONNECTSTART, NETCOMMANDTYPE_DISCONNECTEND), and restores the DEBUG_CRASH guard on the default branch per the discussion on the previous thread.

Confidence Score: 5/5

Safe to merge — all refactored switch statements cover exactly the same enum values as the original if/else chains, and the previous thread concerns have been resolved.

The diff is a pure structural refactor: every function's return-true set was manually cross-checked and is identical to the original. CommandRequiresAck now correctly delegates rather than maintaining a separate (previously duplicate-containing) list. The DEBUG_CRASH on the unhandled default in GetNetCommandTypeAsString has been restored. The three newly added enum literals in the string function are additions, not removals. No logic paths changed.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameNetwork/NetworkUtil.cpp	Refactored four if/else chain functions to switch statements; CommandRequiresAck simplified to delegate to DoesCommandRequireACommandID; GetNetCommandTypeAsString updated with CASE_LABEL macro, three new enum values, and DEBUG_CRASH restored on default. All functional sets verified equivalent.
Core/GameEngine/Include/GameNetwork/networkutil.h	CommandRequiresAck and CommandRequiresDirectSend signatures updated to take const NetCommandMsg* — a straightforward const-correctness improvement matching the implementation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CommandRequiresAck\nconst NetCommandMsg*] -->|delegates to| B[DoesCommandRequireACommandID\nNetCommandType]
    C[CommandRequiresDirectSend\nconst NetCommandMsg*] -->|switch on getNetCommandType| D{DirectSend\nenum set}
    B -->|switch on type| E{CommandID\nenum set}
    F[IsCommandSynchronized\nNetCommandType] -->|switch on type| G{Sync\nenum set}
    H[GetNetCommandTypeAsString\nNetCommandType] -->|CASE_LABEL macro| I{All enum values\n+ UNKNOWN/START/END}
    E -->|match| J[TRUE]
    E -->|default| K[FALSE]
    D -->|match| J
    D -->|default| K
    G -->|match| J
    G -->|default| K
    I -->|match| L[return name string]
    I -->|default| M[DEBUG_CRASH +\nreturn NETCOMMANDTYPE_INVALID]

Loading

_{Reviews (7): Last reviewed commit: "Moved default case for 'GetNetCommandTyp..." | Re-trigger Greptile}

[xezon]

This one goes to the top, in order.