tighten design clocks - #4456
Open
eder-matheus wants to merge 3 commits into
Open
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule and tightens the clock periods for the jpeg_encoder and gcd designs, resulting in updated baseline rules (such as area, wirelength, and timing slack) across several test cases. However, the feedback highlights that these clock period reductions introduce severe timing violations. Specifically, in gcd, the 0.25 ns clock period combined with hardcoded clock latency leaves insufficient time for the data path, while in jpeg_encoder, the 545 ps target severely over-constrains the design, causing massive setup Total Negative Slack (TNS) that could destabilize regression tests.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 4 with regression(s), 0 without a comparable baseline.
❌ asap7/jpeg base — 7 failing metric(s)
❌ nangate45/bp_multi_top base — 1 failing metric(s)
❌ nangate45/dynamic_node base — 8 failing metric(s)
❌ nangate45/gcd base — 10 failing metric(s)
|
…ate/OpenROAD-flow-scripts into tighten_design_clocks Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WARNING] Multiple clocks not supported. Will use first clock: core_clock: 0.2500.
designs/nangate45/gcd/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: clk: 2.0000.
designs/nangate45/dynamic_node/rules-base.json updates:
designs/asap7/jpeg/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: CLK: 3.4000.
designs/nangate45/bp_multi_top/rules-base.json updates: