Implement copy/get_slice/get_global_contact_positions for probegroup#416
Implement copy/get_slice/get_global_contact_positions for probegroup#416alejoe91 merged 8 commits intoSpikeInterface:mainfrom
Conversation
for more information, see https://pre-commit.ci
…face into probegroup-get-slice
for more information, see https://pre-commit.ci
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
Looks good tme, some small comments.
…face into probegroup-get-slice
for more information, see https://pre-commit.ci
|
@h-mayorquin thanks for the comments! All addressed :) |
| contact_positions = np.vstack([probe.contact_positions for probe in self.probes]) | ||
| return contact_positions | ||
|
|
||
| def get_slice(self, selection: np.ndarray[bool | int]) -> "ProbeGroup": |
There was a problem hiding this comment.
Here we strongly need to discuss this behavior.
Does the slice is probe by probe concatenated or is the slice is on channel_devcide_index ordered ?
This is very very important when handling several probes!!! sometimes channel indices are interleaved!!
And so the result will not be the same.
|
We need to be very very carefull with probegroup slicing and if we remove the contact vertor in spikeinterface. |
3 participants
As in title