Refactor probegroup to be array-based#420
Open
alejoe91 wants to merge 2 commits intoSpikeInterface:mainfrom
Open
Refactor probegroup to be array-based#420alejoe91 wants to merge 2 commits intoSpikeInterface:mainfrom
alejoe91 wants to merge 2 commits intoSpikeInterface:mainfrom
Conversation
for more information, see https://pre-commit.ci
| from .probe import Probe | ||
|
|
||
|
|
||
| class ProbeGroup: |
Member
There was a problem hiding this comment.
@alejoe91 we should make a very clear doc here for the new behavior.
We could explain teh why (need of global conact order across probes)
And also metioning the previous behavior (list of probe) and what cannot be possible now (annotate after)
Member
|
There is still an issue with this PR we need to solve : the to_dict/from_dict() and json will NOT preserve the contact order... We need to find something for it!!! Give me a chance to add more complex test for orderings the probe group and global channel indices. I propose a switch of version to 0.4. |
Collaborator
|
I am taking a look. I will publish a review later today |
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #416 we extended the
ProbeGroupwith aget_slicemethod. However, the current probe-centric implementation makes it difficult to slice in device channel indices from different probes are interleaved.This PR refactors the
ProbeGroupto be based on a_self.contact_array:_self.contact_arrayand we store probe contours and annotations (contact_annotations are in the array)probesis not a property that reconstructs the probes on-the-flyannotate_probe(probe_index, **kwargs)to annotate probes in the probe groupRelated to SpikeInterface/spikeinterface#4465, since we want to store a
probegroupobject directly, but we need to sort it/silce it according to thedevice_channel_indices