Draft
Conversation
5 tasks
This was referenced Mar 31, 2026
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c65984a to
bf92dc4
Compare
96d95ba to
d8b0d4a
Compare
6e09feb to
5c1ddf1
Compare
d8b0d4a to
f042d96
Compare
5c1ddf1 to
06dee38
Compare
06dee38 to
40bf3e5
Compare
8cc6cc8 to
cc438ef
Compare
isaacroldan
reviewed
Apr 9, 2026
| * Run client steps that aren't handled by esbuild (e.g. include_assets). | ||
| * Skips bundle_ui since esbuild already handled it. | ||
| */ | ||
| private async runPostEsbuildSteps(extension: ExtensionInstance): Promise<void> { |
Contributor
There was a problem hiding this comment.
we need to find a better way to do this, @alfonso-noriega it makes sense for dev to execute this missing steps. Wonder how much we gain from having a custom esbuild for dev (in theory is faster because it uses contexts and only rebuilds what changed, not the whole extension)
Contributor
There was a problem hiding this comment.
I have an agent working on this, will have an independent PR solving this on monday morning
Member
Author
There was a problem hiding this comment.
Thank you so much Isaac!
cc438ef to
91e9fca
Compare
Include built assets in the manifest.json Allow serving static assets from the extensions directory
91e9fca to
a6d5ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
This change modernizes the UI extension asset handling system by replacing the legacy
build_manifestapproach with a new manifest.json-based system that supports additional asset types including intents.Related https://github.com/shop/issues-admin-extensibility/issues/2274
WHAT is this pull request doing?
intentsfield in extension point schemas with type, action, schema, name, and description propertiesIntentsto theAssetIdentifierenum for asset handlinginclude_assetsstep instead ofcopy_static_assets, with support for tools, instructions, and intent schemasHow to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist