Support assets for admin links app intents#7132
Support assets for admin links app intents#7132vividviolet wants to merge 2 commits into03-31-support_intents_for_ui_extensionsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success4003 tests passing in 1529 suites. Report generated by 🧪jest coverage report action from 8285bfa |
cd40db3 to
c65984a
Compare
8285bfa to
b6f06e9
Compare
b6f06e9 to
c9ad45a
Compare
c65984a to
96d95ba
Compare
96d95ba to
d8b0d4a
Compare
c9ad45a to
5c93642
Compare
5c93642 to
43ebe94
Compare
43ebe94 to
f5b0e94
Compare
6e09feb to
5c1ddf1
Compare
f5b0e94 to
7dc8946
Compare
5c1ddf1 to
06dee38
Compare
7dc8946 to
ce6f08e
Compare
06dee38 to
40bf3e5
Compare
ce6f08e to
35abde3
Compare
8ce58c4 to
8b3cc8d
Compare
0ecbba1 to
0a2c576
Compare
8cc6cc8 to
cc438ef
Compare
0a2c576 to
1b0bbfa
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260408155200Caution After installing, validate the version by running |
cc438ef to
91e9fca
Compare
1b0bbfa to
53479bd
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui.d.ts import { Logger, LogLevel } from '../../public/node/output.js';
-import React from 'react';
import { Key, RenderOptions } from 'ink';
import { EventEmitter } from 'events';
-/**
- * Signal that the current Ink tree is done. Must be called within an
- * InkLifecycleRoot — throws if the provider is missing so lifecycle
- * bugs surface immediately instead of silently hanging.
- */
-export declare function useComplete(): (error?: Error) => void;
-/**
- * Root wrapper for Ink trees. Owns the single `exit()` call site — children
- * signal completion via `useComplete()`, which sets state here. The `useEffect`
- * fires post-render, guaranteeing all batched state updates have been flushed
- * before the tree is torn down.
- */
-export declare function InkLifecycleRoot({ children }: {
- children: React.ReactNode;
-}): React.JSX.Element;
interface RenderOnceOptions {
logLevel?: LogLevel;
logger?: Logger;
renderOptions?: RenderOptions;
}
export declare function renderOnce(element: JSX.Element, { logLevel, renderOptions }: RenderOnceOptions): string | undefined;
-export declare function render(element: JSX.Element, options?: RenderOptions): Promise<void>;
+export declare function render(element: JSX.Element, options?: RenderOptions): Promise<unknown>;
export declare class Stdout extends EventEmitter {
columns: number;
rows: number;
readonly frames: string[];
private _lastFrame?;
constructor(options: {
columns?: number;
rows?: number;
});
write: (frame: string) => void;
lastFrame: () => string | undefined;
}
export declare function handleCtrlC(input: string, key: Key, exit?: () => void): void;
export {};
packages/cli-kit/dist/public/node/ui.d.ts@@ -34,7 +34,7 @@ export interface RenderConcurrentOptions extends PartialBy<ConcurrentOutputProps
* 00:00:00 │ frontend │ third frontend message
*
*/
-export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<void>;
+export declare function renderConcurrent({ renderOptions, ...props }: RenderConcurrentOptions): Promise<unknown>;
export type AlertCustomSection = CustomSection;
export type RenderAlertOptions = Omit<AlertOptions, 'type'>;
/**
|
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260410054217Caution After installing, validate the version by running |
91e9fca to
a6d5ab9
Compare
53479bd to
71d70cf
Compare

WHY are these changes introduced?
Enables assets uploading for
admin_linkto support intentsRelated to https://github.com/shop/issues-admin-extensibility/issues/2205
WHAT is this pull request doing?
admin_linkextension specification with localization supportHow to test your changes?
admin_linkMeasuring impact
How do we know this change was effective? Please choose one:
Checklist