Skip to content

feat: add GPT-5.4 Codex fast mode models (spark variants) #12114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-v0 wants to merge 1 commit into
base: main
Choose a base branch
from
+92 −12
Draft

feat: add GPT-5.4 Codex fast mode models (spark variants) #12114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions packages/types/src/providers/openai-codex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,48 @@ export const openAiCodexModels = {
supportsTemperature: false,
description: "GPT-5.1 Codex Mini: Faster version for coding tasks via ChatGPT subscription",
},
"gpt-5.4-codex": {
maxTokens: 128000,
contextWindow: 1_050_000,
includedTools: ["apply_patch"],
excludedTools: ["apply_diff", "write_to_file"],
supportsImages: true,
supportsPromptCache: true,
supportsReasoningEffort: ["low", "medium", "high", "xhigh"],
reasoningEffort: "medium",
inputPrice: 0,
outputPrice: 0,
supportsTemperature: false,
description: "GPT-5.4 Codex: GPT-5.4 optimized for agentic coding via ChatGPT subscription",
},
"gpt-5.4-codex-spark": {
maxTokens: 8192,
contextWindow: 128000,
includedTools: ["apply_patch"],
excludedTools: ["apply_diff", "write_to_file"],
supportsImages: false,
supportsPromptCache: true,
supportsReasoningEffort: ["low", "medium", "high", "xhigh"],
reasoningEffort: "medium",
inputPrice: 0,
outputPrice: 0,
supportsTemperature: false,
description: "GPT-5.4 Codex Spark: Fast, text-only coding model via ChatGPT subscription",
},
"gpt-5.4-mini-codex-spark": {
maxTokens: 8192,
contextWindow: 128000,
includedTools: ["apply_patch"],
excludedTools: ["apply_diff", "write_to_file"],
supportsImages: false,
supportsPromptCache: true,
supportsReasoningEffort: ["low", "medium", "high", "xhigh"],
reasoningEffort: "medium",
inputPrice: 0,
outputPrice: 0,
supportsTemperature: false,
description: "GPT-5.4 Mini Codex Spark: Fast, text-only mini coding model via ChatGPT subscription",
},
"gpt-5.4": {
maxTokens: 128000,
contextWindow: 1_050_000,
Expand Down
62 changes: 50 additions & 12 deletions src/api/providers/__tests__/openai-codex.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,25 @@
import { OpenAiCodexHandler } from "../openai-codex"

describe("OpenAiCodexHandler.getModel", () => {
it.each(["gpt-5.1", "gpt-5", "gpt-5.1-codex", "gpt-5-codex", "gpt-5-codex-mini", "gpt-5.3-codex-spark"])(
"should return specified model when a valid model id is provided: %s",
(apiModelId) => {
const handler = new OpenAiCodexHandler({ apiModelId })
const model = handler.getModel()

expect(model.id).toBe(apiModelId)
expect(model.info).toBeDefined()
// Default reasoning effort for GPT-5 family
expect(model.info.reasoningEffort).toBe("medium")
},
)
it.each([
"gpt-5.1",
"gpt-5",
"gpt-5.1-codex",
"gpt-5-codex",
"gpt-5-codex-mini",
"gpt-5.3-codex-spark",
"gpt-5.4-codex",
"gpt-5.4-codex-spark",
"gpt-5.4-mini-codex-spark",
])("should return specified model when a valid model id is provided: %s", (apiModelId) => {
const handler = new OpenAiCodexHandler({ apiModelId })
const model = handler.getModel()

expect(model.id).toBe(apiModelId)
expect(model.info).toBeDefined()
// Default reasoning effort for GPT-5 family
expect(model.info.reasoningEffort).toBe("medium")
})

it("should fall back to default model when an invalid model id is provided", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "not-a-real-model" })
Expand All @@ -41,4 +48,35 @@ describe("OpenAiCodexHandler.getModel", () => {
expect(model.id).toBe("gpt-5.4-mini")
expect(model.info).toBeDefined()
})

it("should use GPT-5.4 Codex capabilities when selected", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "gpt-5.4-codex" })
const model = handler.getModel()

expect(model.id).toBe("gpt-5.4-codex")
expect(model.info.contextWindow).toBe(1_050_000)
expect(model.info.maxTokens).toBe(128000)
expect(model.info.supportsImages).toBe(true)
expect(model.info.reasoningEffort).toBe("medium")
})

it("should use GPT-5.4 Codex Spark-specific limits and capabilities", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "gpt-5.4-codex-spark" })
const model = handler.getModel()

expect(model.id).toBe("gpt-5.4-codex-spark")
expect(model.info.contextWindow).toBe(128000)
expect(model.info.maxTokens).toBe(8192)
expect(model.info.supportsImages).toBe(false)
})

it("should use GPT-5.4 Mini Codex Spark-specific limits and capabilities", () => {
const handler = new OpenAiCodexHandler({ apiModelId: "gpt-5.4-mini-codex-spark" })
const model = handler.getModel()

expect(model.id).toBe("gpt-5.4-mini-codex-spark")
expect(model.info.contextWindow).toBe(128000)
expect(model.info.maxTokens).toBe(8192)
expect(model.info.supportsImages).toBe(false)
})
})
Loading