feat: add GPT-5.4 Codex fast mode models (spark variants)#12114
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add GPT-5.4 Codex fast mode models (spark variants)#12114roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
Adds three new model entries to the OpenAI Codex provider: - gpt-5.4-codex: Full GPT-5.4 optimized for agentic coding (1M context) - gpt-5.4-codex-spark: Fast, text-only GPT-5.4 variant (128k context, 8k output) - gpt-5.4-mini-codex-spark: Fast, text-only GPT-5.4 Mini variant (128k context, 8k output) Follows the same pattern as existing gpt-5.3-codex and gpt-5.3-codex-spark models. Closes #12112
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #12112.
Summary
Adds three new model entries to the OpenAI Codex provider for GPT-5.4 fast mode support:
These follow the same pattern as the existing
gpt-5.3-codexandgpt-5.3-codex-sparkmodels, with spark variants providing faster responses by trading off context window size and image support.Changes
packages/types/src/providers/openai-codex.ts: Added 3 new model definitionssrc/api/providers/__tests__/openai-codex.spec.ts: Added tests for the new modelsTest plan
openai-codex.spec.tsFeedback and guidance are welcome.
Interactively review PR in Roo Code Cloud