Skip to content

fix: Wrong code generation for FieldImage #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 1 commit into from
Jul 27, 2026
+6 −1
Merged

fix: Wrong code generation for FieldImage #2755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion examples/developer-tools/src/output-generators/fields/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ javascriptDefinitionGenerator.forBlock['field_image'] = function (
const alt = generator.quote_(block.getFieldValue('ALT'));
const flipRtl = block.getFieldValue('FLIP_RTL') === 'TRUE';

const code = `.appendField(new Blockly.FieldImage(${src}, ${width}, ${height}, { alt: ${alt}, flipRtl: ${flipRtl}}))`;
const args = [src, width, height, alt];
if (flipRtl) {
// The onClick handler argument precedes flipRtl in the constructor.
args.push('undefined', 'true');
}
const code = `.appendField(new Blockly.FieldImage(${args.join(', ')}))`;
return code;
};

Expand Down
Loading