Skip to content

fix: Wrong code generation for FieldImage - #2755

Merged
gonfunko merged 1 commit into
RaspberryPiFoundation:mainfrom
TannerGabriel:fix/block-factory-fieldimage
Jul 27, 2026
Merged

fix: Wrong code generation for FieldImage#2755
gonfunko merged 1 commit into
RaspberryPiFoundation:mainfrom
TannerGabriel:fix/block-factory-fieldimage

Conversation

@TannerGabriel

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #2691

Other optional implementations

Alternatively, we could pass the alt and fieldRtl into the config, which is now the seventh, but I think this is the clearer approach.

new Blockly.FieldImage(src, width, height, undefined, undefined, undefined, {alt: 'star', flipRtl: true})

@TannerGabriel
TannerGabriel requested a review from a team as a code owner July 26, 2026 20:14
@TannerGabriel
TannerGabriel requested review from gonfunko and removed request for a team July 26, 2026 20:14
@gonfunko

Copy link
Copy Markdown
Contributor

Thanks for the fix for this!

@gonfunko
gonfunko merged commit 7a39ad3 into RaspberryPiFoundation:main Jul 27, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

block factory generates incorrect javascript definitions for FieldImage

2 participants