Stdlib: DOMXPath::quote() — PHP 8.4 XPath literal escaping (#18650)#18651
Merged
Conversation
Adds the static escaper from php-src ext/dom/xpath.c behind the 8.4 profile gate so XPath queries can safely embed quoted attribute values without new C runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate bootstrap-inventory.md after conflict resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 13, 2026
PurHur
added a commit
that referenced
this pull request
Jul 13, 2026
) * Bootstrap: resync inventory after NamedArgs variadic fix (#18653) Regenerate docs/bootstrap-inventory.md so bootstrap-inventory --check matches lib/JIT/NamedArgs.php and related vm.php-path drift from #18653. Refs #1492 Co-authored-by: Cursor <cursoragent@cursor.com> * Bootstrap: extend lib spine for DOM XPathQuote + session handlers Append four vm.php-path inventory files missing from compiler_lib_spine_smoke so check-selfhost-spine-coverage-sync passes after #18650/#18651 extension additions. Refs #1492 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMXPath::quote(string $str): stringfrom php-srcext/dom/xpath.c(single-quote, double-quote, andconcat()fallback).CompilerVersion::supportsDomXPathQuote()(8.4.0+ forward profile; withheld onPHP_COMPILER_PROFILE=8.2).ValueErrorlike php-src Regression: public protected(set)/public private(set) — compiles not compile fatal (re-#10334, Zend/zend_compile.c) #13960.php-src reference
ext/dom/xpath.c—PHP_METHOD(DOMXPath, quote)PHP implementation
ext/dom/XPathQuote.php— static VM handlerext/dom/VmDomXPath.php— quoting coreext/dom/VmDom.php— registration gatelib/CompilerVersion.php—supportsDomXPathQuote()Closes #18650
Verification
Test plan
test/compliance/cases/dom/dom_xpath_quote.phptmethod_existsfalse)Made with Cursor