Fix: Enable MPPI open-loop control on Jazzy - #867
Draft
picknik-johnny-5-bot[bot] wants to merge 1 commit into
Draft
Fix: Enable MPPI open-loop control on Jazzy#867picknik-johnny-5-bot[bot] wants to merge 1 commit into
picknik-johnny-5-bot[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Motivation
The Jazzy MPPI controller uses lagging odometry to seed each optimization cycle, limiting commanded base speed in
hangar_sim. Upstream navigation2#6336 adds an opt-inopen_loopmode that seeds from the previous command.Refs PickNikRobotics/moveit_pro#21730.
Brief description
FollowPath.open_loopin the Jazzy-only Nav2 parameter file introduced by parent PR Fix: Select hangar_sim nav2 params by ROS distro so Jazzy navigation starts #863.This is a stacked draft based on #863.
Blocking dependencies
Do not mark ready or merge until:
FollowPath.open_loop=Trueand confirms the commanded-speed regression is fixed.How it was tested
python -m pytest -q src/hangar_sim/test/nav2_params_distro_parity_test.py— 5 passed.pre-commit run --files src/hangar_sim/params/nav2_params_jazzy.yaml src/hangar_sim/test/nav2_params_distro_parity_test.py— all applicable hooks passed.git diff --check origin/pr-863-current...HEAD— passed.A code-reviewer, test-runner, and platform-architecture review passed with no required changes. Runtime testing remains blocked on publication of the upstream Jazzy package.
Release notes