[codex] expose subtle encapsulation method surface#4291
Merged
proggeramlug merged 1 commit intoJun 4, 2026
Merged
Conversation
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #2518.
This PR adds the WebCrypto
SubtleCryptoencapsulation method surface:encapsulateBits,decapsulateBits,encapsulateKey, anddecapsulateKeyonSubtleCrypto.prototypecrypto.subtlenamespace property reads and captured method calls to callable runtime thunksname,length, descriptor shape, Promise-returning missing-argument rejections, and captured-callERR_INVALID_THISNotSupportedErrorinstead of falling through as missing methodsWhy batched
The four helpers share the same
SubtleCryptoprototype installation,crypto.subtlenamespace property-read path, captured-call receiver validation, and stdlib WebCrypto dispatch surface. Splitting them would duplicate the runtime plumbing and leave the method family in a partially reflective state.Tests
Added
test-parity/node-suite/crypto/webcrypto/encapsulation-method-surface.ts, covering:crypto.webcrypto.subtleSubtleCrypto.prototypedescriptor shapenameandlengthERR_INVALID_THISValidation
npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/crypto/webcrypto/encapsulation-method-surface.tscargo check -p perry-runtime -p perry-stdlibPERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter encapsulation-method-surface'/root/perry-worktrees/perry-node-crypto-subtle-encapsulate-surface/test-parity/reports/parity_report_20260603_192724.jsonPERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter global-webcrypto-globals'PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter subtle-supports'CARGO_TARGET_DIR=/tmp/perry-subtle-encapsulation-crypto-check cargo check -p perry-stdlib --no-default-features --features cryptocargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shKnown limitations
This does not implement ML-KEM encapsulation or decapsulation. Calls that reach the new execution stubs reject explicitly as unsupported.
Non-goals
SubtleCrypto.supports()reporting