[codex] expose subtle encapsulation method surface#4292
Closed
andrewtdiz wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2518.
Scope
SubtleCrypto.prototype.encapsulateBits,decapsulateBits,encapsulateKey, anddecapsulateKeywith Node-shaped callable method names, lengths, and enumerable/writable/configurable descriptors.crypto.subtlecalls plus captured/dynamiccrypto.subtlemethod calls through the WebCrypto dispatcher instead of surfacingundefined.TypeError [ERR_MISSING_ARGS]and the WebIDL-style message.Non-goals
SubtleCrypto.supports().Validation
npm exec --yes --package=node@26 -- node test-parity/node-suite/crypto/webcrypto/subtle-encapsulation-methods.tsCARGO_TARGET_DIR=/tmp/perry-webcrypto-encap-check cargo check -p perry-hir -p perry-codegen -p perry-runtime -p perry-stdlibtest-parity/node-suite/crypto/webcrypto/subtle-encapsulation-methods.tswithPERRY_NO_AUTO_OPTIMIZE=1PERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-webcrypto-encap-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter subtle-encapsulation-methods'PERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-webcrypto-encap-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter subtle-supports'PERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-webcrypto-encap-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter global-webcrypto-globals'cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh