[style][tinker] Restore Black-clean main - #2009
Closed
bvolpato wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 10, 2026
Contributor
Author
|
duplicates #2002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Current main fails check_code_quality because Black rewrites tests/tinker/test_engine.py. File is missing required separation between two top-level functions. Since CI runs pre-commit over all files, every pull request based on this commit inherits same failure before train and gym jobs can proceed.
Same unchanged-file failure is visible on #2005, #2006, and #2007.
Change
Apply exact Black output: add two blank lines between top-level test functions. No executable statement changes.
Why this belongs upstream
Failure exists on main rather than contributor diffs. Fixing base once restores useful formatting signal for every branch and avoids copying unrelated whitespace into each pull request.
Validation
No runtime test added because this is formatting-only.