Skip to content

[style][tinker] Restore Black-clean main - #2009

Closed
bvolpato wants to merge 1 commit into
NovaSky-AI:mainfrom
bvolpato:bvolpato/format-tinker-engine
Closed

[style][tinker] Restore Black-clean main#2009
bvolpato wants to merge 1 commit into
NovaSky-AI:mainfrom
bvolpato:bvolpato/format-tinker-engine

Conversation

@bvolpato

@bvolpato bvolpato commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Problem

Current main fails check_code_quality because Black rewrites tests/tinker/test_engine.py. File is missing required separation between two top-level functions. Since CI runs pre-commit over all files, every pull request based on this commit inherits same failure before train and gym jobs can proceed.

Same unchanged-file failure is visible on #2005, #2006, and #2007.

Change

Apply exact Black output: add two blank lines between top-level test functions. No executable statement changes.

Why this belongs upstream

Failure exists on main rather than contributor diffs. Fixing base once restores useful formatting signal for every branch and avoids copying unrelated whitespace into each pull request.

Validation

  • pre-commit run --all-files --config .pre-commit-config.yaml
  • Ruff passed
  • Black passed
  • hardcoded-secret scan passed
  • GitHub check_code_quality passed
  • GitHub skyrl_gym_tests passed

No runtime test added because this is formatting-only.

@bvolpato

Copy link
Copy Markdown
Contributor Author

duplicates #2002

@bvolpato bvolpato closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant